Ref T8424. This adds crude integration with Paste's edit/view workflows: you can change the space a Paste appears in, see transactions, and get a policy callout.
Lots of rough edges and non-obviousness but it pretty much works.
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T8424: Integrate Spaces into the core policy infrastructure
- Commits
- Restricted Diffusion Commit
rPef90007a2120: Support Spaces transactions
- Created and updated Pastes.
- Moved them between spaces, saw policy effects.
- Read transactions.
- Looked at feed.
- Faked query to return no spaces, saw control and other stuff vanish.
- Faked query to return no spaces, created pastes.
- Tried to submit bad values and got errors.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Edit UI doens't make it very clear what the control does. Maybe we merge it into "Visible To"?
So it becomes something like:
Visible To: <Space> <Policy>
Transactions are fine, I tried to be slightly playful/distinctive while still being clear/businessey by using the somewhat-distinctive word "shifted":
Header works but is a bit rough:
Maybe some sort of "Space > Policy" treatment there too.
Comment Actions
Visible To: <Space> <Policy>
Or maybe this would be more clear:
Visible To: <Policy> in <Space>
It reads better ("All Users" in "Phacility") but the policies are hierarchical in the other order. I could go either way.
Comment Actions
My rough plan was to put the space in with the title, just it another color (fire).
OPS | Build new tier for messaging
Comment Actions
Actually, I guess we rarely/never use setObjectName() in other applications; let me get rid of that.
Comment Actions
Other ideas would be:
Use spaces icon? I think?
Make space names all caps?
Unique color?
Comment Actions
Spaces icon is currently , should I swap that to ? Compass feels sort-of clear to me while table is sort-of meaningless but maybe that's just me.
Comment Actions
I though I snuck it in, but maybe not. Pure black would be another option. Just some differentiation like we do with obj name on cards
Comment Actions
(At least so far, we don't have any actual product reason to require Spaces to be callsign-like or ALLCAPS, and I'm not sure we actually will, so I want to try to stick with the flexibility of naming them whatever you want until we run into trouble or hit some UI that's not clear or whatever.)
Comment Actions
Another random thought, let people pick an icon per space. Gives ability to identify space in ... smaller spaces.
Comment Actions
I like shifted and I thought of "translocated" which is fancy for "moved" more or less.
The all black boldish header looks good to me to start.
In the future I like @chad's idea about having custom icons; I feel like the project icon picker thing could be useful here, in conpherence, who knows where else as a nice way for users to visually unify projects. (Of course, maybe we just need to make more things part of a given project so the icon automagically goes places? I digress)
| src/applications/transactions/constants/PhabricatorTransactions.php | ||
|---|---|---|
| 15 | bold move | |
| src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php | ||
| 2037 | maybe shift into or what have you instead of put? | |
Comment Actions
If we do the global menu I think I'll definitely pursue the icon thing, although I think Calendar and Projects already stole all the good icons. I'll see what's left and maybe just do this regardless if I can come up with 8-ish reasonable icons that we aren't using somewhere already.