Migrate Herald conditions and actions after mailing list changes
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 1:33 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Commits

Summary

Ref T8455. It looks like for at least some installs, there are a lot of rules which use mailing lists and they aren't easy to just manually go fix.

Migrate conditions and actions of known types which contain mailing list PHIDs from old MLST PHIDs to new USER PHIDs.

Test Plan

Created a "Subscribers include..." condition using a mailing list, migrated it forward into a user.
Created a "add ccs..." action including a mailing list, migrated it forward into a user.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley retitled this revision from to Migrate Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley retitled this revision from Migrate Herald to Migrate Herald conditions and actions after mailing list changes.Jun 6 2015, 1:33 PM

btrahan edited edge metadata.

btrahan added inline comments.

resources/sql/autopatches/20150606.mlist.1.php
57	Is this totally whatevs or should we let the administrator know or be prepared for some esoteric bug reports or?

This revision is now accepted and ready to land.Jun 8 2015, 5:03 PM

resources/sql/autopatches/20150606.mlist.1.php
57	Oh, sorry, I phrased this badly. I'll make it more clear. I just meant it's a condition type that we don't specifically know contains mailing list PHIDs. In all cases (hopefully) it's a condition we know about, it's just one of the other conditions like "Filename matches path" or "Always" or "Is merge commit" or "Status is one of...". In these cases, we don't look through the value because it won't have any mailing lists in it (since it's empty, or a string, or a boolean, or a list of other PHID types, or something else).

Clarify that we're skipping actions and conditions which have some other kind of value (a string, regexp, message, etc.), where we don't expect to find a list of PHIDs which may contain mailing list PHIDs.

This revision was automatically updated to reflect the committed changes.