Page MenuHomePhabricator
Differential D13184

Migrate Herald conditions and actions after mailing list changes
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 1:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 7:21 PM
Unknown Object (File)
Thu, Nov 28, 3:53 AM
Unknown Object (File)
Thu, Nov 28, 3:53 AM
Unknown Object (File)
Thu, Nov 21, 10:27 AM
Unknown Object (File)
Thu, Nov 21, 10:27 AM
Unknown Object (File)
Thu, Nov 21, 10:27 AM
Unknown Object (File)
Thu, Nov 21, 10:26 AM
Unknown Object (File)
Thu, Nov 21, 10:05 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8455: Herald rules with mailing lists are broken after mailing list -> user migration
Commits
Restricted Diffusion Commit
rP00d1aea56fdb: Migrate Herald conditions and actions after mailing list changes
Summary

Ref T8455. It looks like for at least some installs, there are a lot of rules which use mailing lists and they aren't easy to just manually go fix.

Migrate conditions and actions of known types which contain mailing list PHIDs from old MLST PHIDs to new USER PHIDs.

Test Plan
  • Created a "Subscribers include..." condition using a mailing list, migrated it forward into a user.
  • Created a "add ccs..." action including a mailing list, migrated it forward into a user.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31864.Jun 6 2015, 1:33 PM
epriestley retitled this revision from to Migrate Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8455: Herald rules with mailing lists are broken after mailing list -> user migration.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 6 2015, 1:33 PM
epriestley retitled this revision from Migrate Herald to Migrate Herald conditions and actions after mailing list changes.Jun 6 2015, 1:33 PM
chad mentioned this in T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.Jun 8 2015, 10:32 AM
btrahan accepted this revision.Jun 8 2015, 5:03 PM
btrahan edited edge metadata.
btrahan added inline comments.
resources/sql/autopatches/20150606.mlist.1.php
57

Is this totally whatevs or should we let the administrator know or be prepared for some esoteric bug reports or?

This revision is now accepted and ready to land.Jun 8 2015, 5:03 PM
epriestley added inline comments.Jun 8 2015, 5:27 PM
resources/sql/autopatches/20150606.mlist.1.php
57

Oh, sorry, I phrased this badly. I'll make it more clear.

I just meant it's a condition type that we don't specifically know contains mailing list PHIDs. In all cases (hopefully) it's a condition we know about, it's just one of the other conditions like "Filename matches path" or "Always" or "Is merge commit" or "Status is one of...". In these cases, we don't look through the value because it won't have any mailing lists in it (since it's empty, or a string, or a boolean, or a list of other PHID types, or something else).

epriestley updated this revision to Diff 31913.Jun 8 2015, 5:28 PM
epriestley edited edge metadata.
  • Clarify that we're skipping actions and conditions which have some other kind of value (a string, regexp, message, etc.), where we don't expect to find a list of PHIDs which may contain mailing list PHIDs.
Closed by commit rP00d1aea56fdb: Migrate Herald conditions and actions after mailing list changes (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:32 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T8455: Herald rules with mailing lists are broken after mailing list -> user migration.Jun 8 2015, 5:58 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
152 lines

Diff 31922

View Options

resources/sql/autopatches/20150606.mlist.1.php

Loading...
Phabricator · Built by Phacility