Paths

Table of Contentst

Differential D13178

Make ACTION_NOTHING a "standard" action in Herald
ClosedPublic
Actions

Authored by epriestley on Jun 6 2015, 11:40 AM.

Tags

None

Referenced Files

	F15796292: D13178.id31857.diff
	Fri, May 30, 10:15 AM

	F15781091: D13178.id31915.diff
	Fri, May 30, 7:22 AM

	Unknown Object (File)
	Thu, May 29, 5:31 AM

	Unknown Object (File)
	Wed, May 28, 4:15 PM

	Unknown Object (File)
	Thu, May 8, 2:49 AM

	Unknown Object (File)
	Fri, May 2, 2:54 PM

	Unknown Object (File)
	Apr 29 2025, 4:54 PM

	Unknown Object (File)
	Apr 28 2025, 11:34 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T8455: Herald rules with mailing lists are broken after mailing list -> user migration

Commits

Restricted Diffusion Commit
rPce434e821c7b: Make ACTION_NOTHING a "standard" action in Herald

Summary

Ref T8455. Multiple adapters implement essentially identical effects for ACTION_NOTHING. Consolidate them.

Test Plan

Created several ACTION_NOTHING rules and updated the corresponding objects.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31857.Jun 6 2015, 11:40 AM

epriestley retitled this revision from to Make ACTION_NOTHING a "standard" action in Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 6 2015, 11:40 AM

Also consolidate the action on HeraldDifferentialDiffAdapter.
Fix an issue on HeraldDifferentialDiffAdapter where the action name map wasn't built correctly, preventing the creation of "Do nothing" diff rules from the UI.
Wrote and executed a "Do nothing" diff rule.

epriestley added a child revision: D13180: Use standard subscribers effects in Herald Adapter for Phriction.Jun 6 2015, 12:40 PM

btrahan accepted this revision.Jun 8 2015, 4:18 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 8 2015, 4:18 PM

Closed by commit rPce434e821c7b: Make ACTION_NOTHING a "standard" action in Herald (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2015, 5:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

applications/

diffusion/

herald/

HeraldPreCommitAdapter.php

6 lines

herald/

adapter/

HeraldAdapter.php

8 lines

HeraldCommitAdapter.php

6 lines

HeraldDifferentialDiffAdapter.php

14 lines

HeraldDifferentialRevisionAdapter.php

6 lines

HeraldManiphestTaskAdapter.php

6 lines

HeraldPholioMockAdapter.php

6 lines

phriction/

herald/

PhrictionDocumentHeraldAdapter.php

6 lines

Diff 31915

resources/celerity/map.php

Loading...

src/applications/diffusion/herald/HeraldPreCommitAdapter.php

Loading...

src/applications/herald/adapter/HeraldAdapter.php

Loading...

src/applications/herald/adapter/HeraldCommitAdapter.php

Loading...

src/applications/herald/adapter/HeraldDifferentialDiffAdapter.php

Loading...

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

Loading...

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Loading...

src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php

Loading...