Page MenuHomePhabricator

Make ACTION_NOTHING a "standard" action in Herald
ClosedPublic

Authored by epriestley on Jun 6 2015, 11:40 AM.
Tags
None
Referenced Files
F15567810: D13178.id.diff
Fri, May 2, 2:54 PM
F15560852: D13178.id31858.diff
Tue, Apr 29, 4:54 PM
F15555476: D13178.id31857.diff
Mon, Apr 28, 11:34 AM
F15554598: D13178.id31915.diff
Mon, Apr 28, 7:41 AM
F15549374: D13178.id.diff
Sun, Apr 27, 5:21 AM
F15546619: D13178.diff
Sat, Apr 26, 4:16 PM
F15539309: D13178.id31858.diff
Fri, Apr 25, 12:44 AM
F15527073: D13178.diff
Tue, Apr 22, 12:26 AM
Subscribers

Details

Summary

Ref T8455. Multiple adapters implement essentially identical effects for ACTION_NOTHING. Consolidate them.

Test Plan

Created several ACTION_NOTHING rules and updated the corresponding objects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make ACTION_NOTHING a "standard" action in Herald.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also consolidate the action on HeraldDifferentialDiffAdapter.
  • Fix an issue on HeraldDifferentialDiffAdapter where the action name map wasn't built correctly, preventing the creation of "Do nothing" diff rules from the UI.
  • Wrote and executed a "Do nothing" diff rule.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 8 2015, 4:18 PM
This revision was automatically updated to reflect the committed changes.