Page MenuHomePhabricator

Use DifferentialCommitMessageParser and Modular Transactions to implement "Auditors: ..."
ClosedPublic

Authored by epriestley on Jan 30 2017, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 4, 7:19 PM
Unknown Object (File)
Wed, Aug 3, 10:51 PM
Unknown Object (File)
Wed, Aug 3, 9:45 PM
Unknown Object (File)
Tue, Aug 2, 8:46 AM
Unknown Object (File)
Thu, Jul 14, 10:17 AM
Unknown Object (File)
Thu, Jul 14, 8:41 AM
Unknown Object (File)
Jul 4 2022, 10:15 AM
Unknown Object (File)
Jul 2 2022, 10:49 PM
Subscribers
None

Details

Summary

Ref T10978. Updates how we implement "Auditors: ..." in commit messages:

  • Use the same parsing code as everything else.
    • (Also: parse package names.)
  • Use the new transaction code.

Also, fix some UI strings.

Test Plan

Used bin/repository reparse --herald <commit> to re-run this code on commits with various messages (valid Auditors, invalid Auditors, no Auditors). Saw appropriate auditors added in the UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable