Page MenuHomePhabricator

Excluded authored commits from "Ready to Audit"; handle unreachable commits better
ClosedPublic

Authored by epriestley on Jan 31 2017, 9:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 1, 8:25 PM
Unknown Object (File)
May 31 2025, 6:58 AM
Unknown Object (File)
May 30 2025, 7:29 PM
Unknown Object (File)
May 29 2025, 9:01 AM
Unknown Object (File)
May 28 2025, 9:35 AM
Unknown Object (File)
May 27 2025, 2:17 PM
Unknown Object (File)
May 9 2025, 11:26 PM
Unknown Object (File)
May 5 2025, 9:45 PM
Subscribers
None

Details

Summary

Ref T10978. I'm inching toward cleaning up our audit state. Two issues are:

  • Authored commits show up in "Ready to Audit", but should not.
  • Unreachable commits (like that stacked of unsquashed stuff) show up too, but we don't really care about them.

Kick authored stuff out of the "Ready to Audit" bucket and hide unreachable commits by default, with constraints for filtering. Also give them a closed/disabled/strikethru style.

Test Plan
  • Viewed audit buckets.
  • Searched for reachable/unreachable commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable