Page MenuHomePhabricator

Write an explicit edge for commit membership in packages
ClosedPublic

Authored by epriestley on Jan 30 2017, 7:41 PM.
Tags
None
Referenced Files
F14004121: D17264.id41540.diff
Sat, Oct 26, 3:46 PM
F13997392: D17264.diff
Thu, Oct 24, 4:12 AM
F13997053: D17264.id41531.diff
Thu, Oct 24, 1:52 AM
F13970338: D17264.diff
Oct 17 2024, 7:02 AM
Unknown Object (File)
Oct 11 2024, 11:57 PM
Unknown Object (File)
Oct 11 2024, 11:21 PM
Unknown Object (File)
Oct 11 2024, 11:20 PM
Unknown Object (File)
Oct 11 2024, 11:17 PM
Subscribers
None

Details

Summary

Ref T10978. Currently, during commit import, we write an "Audit Not Required" auditor for commits which don't require an audit.

This auditor is used to power the "Commits in this package" query in Owners.

This conflates audits and commit/package membership. I think it might even predate edges. Code needs to dance around this mess and we get the wrong result in some cases, since auditors are now editable.

Instead, write an explicit edge which just says "this commit is part of such-and-such packages". Then use that to run the query. Logical!

I'll issue guidance on this but I'm not migrating it, since it fixes itself going forward and only really affects the UI in Owners.

Test Plan
  • Ran bin/audit update-owners with various arguments.
  • Viewed packages in web UI, saw them load the proper commits.
  • Queried by packages in Diffusion explicitly.
  • Clicked the "View All" link in Owners and got to the right search UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable