Improve handle batching behavior for commit list view
ClosedPublic
Actions

Authored by epriestley on Jan 18 2017, 8:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 2, 11:59 AM

	Unknown Object (File)
	Fri, Apr 25, 11:18 AM

	Unknown Object (File)
	Apr 5 2025, 7:40 PM

	Unknown Object (File)
	Apr 3 2025, 8:12 AM

	Unknown Object (File)
	Apr 1 2025, 11:32 PM

	Unknown Object (File)
	Mar 25 2025, 1:05 PM

	Unknown Object (File)
	Mar 22 2025, 2:27 AM

	Unknown Object (File)
	Mar 19 2025, 5:37 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10978: Modernize Audit

Commits

rPb8e04fe0419d: Improve handle batching behavior for commit list view

Summary

Ref T10978. Handle loads can be batched a bit more efficiently by doing them upfront.

Test Plan

Queries dropped a bit locally, but I mostly have the same autors/auditors. I'm seeing 286 queries on my account in production, so I'll check what happens with that.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 18 2017, 8:04 PM

Harbormaster completed remote builds in B15316: Diff 41427.Jan 18 2017, 8:05 PM

chad accepted this revision.Jan 18 2017, 8:35 PM

This revision is now accepted and ready to land.Jan 18 2017, 8:35 PM

Closed by commit rPb8e04fe0419d: Improve handle batching behavior for commit list view (authored by epriestley, committed by epriestley). · Explain WhyJan 18 2017, 9:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

view/

PhabricatorAuditListView.php

37 lines

Diff 41433

View Options

src/applications/audit/view/PhabricatorAuditListView.php

Improve handle batching behavior for commit list viewClosedPublicActions