Page MenuHomePhabricator

Make the "Add Auditors" Herald rules use modern transactions
ClosedPublic

Authored by epriestley on Jan 30 2017, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 7:10 PM
Unknown Object (File)
Fri, Nov 8, 11:19 AM
Unknown Object (File)
Fri, Nov 8, 6:30 AM
Unknown Object (File)
Sat, Nov 2, 7:30 AM
Unknown Object (File)
Sun, Oct 27, 2:52 AM
Unknown Object (File)
Thu, Oct 24, 4:05 PM
Unknown Object (File)
Oct 21 2024, 3:20 PM
Unknown Object (File)
Oct 17 2024, 5:13 PM
Subscribers
None

Details

Summary

Ref T10978. Convert "Add Auditors" rules in Herald to modern modular transactions.

Here and in D17262 (and in the next change), I've removed "audit reasons". There are several reasons for this:

  • They're pretty hacky.
  • They store English-language (well, usually) text in the database, which can't be translated.
  • I think they may not be necessary. When they were written, Herald did not apply transactions, so it was less clear when Herald was doing something. In modern code, it does, so Herald auditors are clear. The owenrs/package rules are now more clear, too. I'd like to see evidence that confusion still exists before rebuilding this feature in a modern, translatable way, since I think we may not need it at all.
Test Plan

Ran bin/repository reparse --herald <commit> to re-run Herald rules. Saw rules add auditors appropriately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable