Page MenuHomePhabricator

Make implicit audits by the Owners tool use modern code
ClosedPublic

Authored by epriestley on Jan 30 2017, 8:22 PM.
Tags
None
Referenced Files
F14001315: D17266.id41533.diff
Fri, Oct 25, 6:21 AM
F13977418: D17266.diff
Fri, Oct 18, 6:29 PM
F13974996: D17266.diff
Oct 18 2024, 8:17 AM
Unknown Object (File)
Oct 13 2024, 5:50 AM
Unknown Object (File)
Oct 11 2024, 11:52 PM
Unknown Object (File)
Oct 11 2024, 11:50 PM
Unknown Object (File)
Oct 11 2024, 11:49 PM
Unknown Object (File)
Oct 11 2024, 11:46 PM
Subscribers
None

Details

Summary

Ref T10978. This updates audits triggered by Owners to use a modern transaction. Minor changes:

  • After D17264, we no longer need the "AUDIT_NOT_REQUIRED" fake-audits to record package membership. This no longer creates them.
  • This previously saved English-language, untranslatable text strings about audit details onto the audit relationship. I've removed them, per discussion in D17263.

The "Audit Reasons" here are potentially a little more useful than the Herald/Explicit-By-Owner ones were, since the rules are a little more complex, but I'd still like to see evidence that we need them.

In particular, the transaction record now says "Owners added auditors: ...", just like Differential, so the source of the auditors should be clear:

Screen Shot 2017-01-30 at 12.09.18 PM.png (120×439 px, 14 KB)

T11118 (roughly "add several Owners audit modes", despite the title at time of writing) might impact this too. Basically, this is simple and maybe good enough; if it's not quite good enough we can refine it.

Test Plan

Ran bin/repository reparse --owners <commit> saw appropriate owners audits trigger.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 30 2017, 10:24 PM
This revision was automatically updated to reflect the committed changes.