Page MenuHomePhabricator
Feed All Stories

Aug 8 2017

chad added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

hmmmmmmmmmmm

Aug 8 2017, 2:34 AM · ApplicationSearch
epriestley created T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.
Aug 8 2017, 1:02 AM · ApplicationSearch

Aug 7 2017

chad closed T12451: Finding your subscriptions / cards on Phacility is non-obvious as Resolved by committing Restricted Diffusion Commit.
Aug 7 2017, 4:01 PM · Phortune, Phacility
epriestley closed T12955: test sub task, a subtask of T9539: For test, as Invalid.
Aug 7 2017, 12:45 PM · Space Test Users
epriestley closed T12955: test sub task as Invalid.
Aug 7 2017, 12:45 PM
epriestley closed T12954: test sub sub task, a subtask of T12953: test sub task, as Invalid.
Aug 7 2017, 12:45 PM
epriestley closed T12954: test sub sub task as Invalid.
Aug 7 2017, 12:45 PM
epriestley closed T12953: test sub task, a subtask of T9539: For test, as Invalid.
Aug 7 2017, 12:44 PM · Space Test Users
epriestley closed T12953: test sub task as Invalid.
Aug 7 2017, 12:44 PM
• zhouxinhu1 created T12955: test sub task.
Aug 7 2017, 6:57 AM
• zhouxinhu1 created T12954: test sub sub task.
Aug 7 2017, 6:57 AM
• zhouxinhu1 created T12953: test sub task.
Aug 7 2017, 6:57 AM
• bingogo009 added a watcher for Bug Report: • bingogo009.
Aug 7 2017, 1:09 AM
• bingogo009 added a watcher for Bug Report (Needs Information): • bingogo009.
Aug 7 2017, 1:08 AM

Aug 6 2017

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Aug 6 2017, 6:51 PM · Lint, Arcanist
chad added a comment to T7729: No Typeahead on Herald object rule creation.

oh thanks!

Aug 6 2017, 3:36 PM · Typeahead, Herald
chad closed T12952: Reviewer not able to see diff as Resolved by committing Restricted Diffusion Commit.
Aug 6 2017, 3:08 PM · Differential, Bug Report
epriestley reopened T7729: No Typeahead on Herald object rule creation as "Open".

I don't think this is resolved, just an unclear report. To access this screen:

Aug 6 2017, 11:50 AM · Typeahead, Herald
epriestley added a comment to T3626: Detection of language for some file types isn't good.

And one more, also for Kotlin.

Aug 6 2017, 11:42 AM · Customer Impact, Restricted Project, Differential
chad closed T7729: No Typeahead on Herald object rule creation as Resolved.

image.png (1×2 px, 218 KB)

Aug 6 2017, 3:59 AM · Typeahead, Herald
chad closed T7739: Redesign Lint/Unit properties as Wontfix.
Aug 6 2017, 3:57 AM · Restricted Project, Harbormaster, Differential
chad closed T7754: View Options Menu doesn't stay relative to the button as Resolved.

No longer reproduces.

Aug 6 2017, 3:55 AM · Mobile, PHUI
joshuaspence updated the task description for T8593: Allow files to have a description.
Aug 6 2017, 3:53 AM · Restricted Project, Files
chad closed T8122: Unable to scroll on mobile if horizontal scroll is available as Invalid.

No longer valid as far as I can find.

Aug 6 2017, 3:52 AM · Google Chrome, PHUI, Mobile
chad closed T8635: Show history of changes to Herald rules as Resolved.

image.png (1×2 px, 311 KB)

Aug 6 2017, 3:49 AM · Restricted Project, Herald
chad closed T8593: Allow files to have a description as Wontfix.

Yeah this feels low value vs. building Dropbox. Closing in favor of overengineering.

Aug 6 2017, 3:48 AM · Restricted Project, Files
chad closed T8878: Make desktop notifications more discoverable as Resolved.

It's discoverable in settings just fine.

Aug 6 2017, 3:44 AM · User Preferences, Notifications
chad closed T8874: Git push to hosted repository slow as Invalid.

Unclear if this is a feature request, bug report, or general question. Going to close out as it's old and not actionable.

Aug 6 2017, 3:44 AM · Diffusion
chad merged task T12421: Can't verify email address if user doesn't have view policy for any space into T9150: Users without access to any spaces cannot use welcome link to set their password.
Aug 6 2017, 3:40 AM · Bug Report
chad merged T12421: Can't verify email address if user doesn't have view policy for any space into T9150: Users without access to any spaces cannot use welcome link to set their password.
Aug 6 2017, 3:40 AM · Auth, Spaces
chad closed T9436: Shift to Space shows on installs with no spaces as Wontfix.

I'm going to wontfix this. Functionally, everything is incorrect on the batch editor on a new install, if you have no users, no projects, no spaces. These don't seem to be too confusing to understand.

Aug 6 2017, 3:38 AM · Spaces
chad closed T10187: hard to understand status of sub-tasks from parent, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Aug 6 2017, 3:33 AM · Maniphest
chad closed T10187: hard to understand status of sub-tasks from parent as Resolved.

I think this is resolved with Related Objects now.

Aug 6 2017, 3:33 AM · Restricted Project, Maniphest
chad merged T11368: Allow to watch only single column of the workboard into T5791: Write Herald rules for outbound mail.
Aug 6 2017, 3:26 AM · Restricted Project, Restricted Project, FreeBSD, Mail
chad merged task T11368: Allow to watch only single column of the workboard into T5791: Write Herald rules for outbound mail.
Aug 6 2017, 3:26 AM · Restricted Project, Maniphest, Workboards, Feature Request
chad added a comment to T12575: All-day reccurring events reoccurr for two days instead of one.

I can confirm this.

Aug 6 2017, 3:22 AM · Calendar, Bug Report
chad closed T11923: Unhandled Exception - Cant import columns for new workboard as Resolved.

Doesn't seem to reproduce any more - I have no issue importing from another milestone. Presumed fixed, but if not, please reopen with more detailed reproduction steps.

Aug 6 2017, 3:20 AM · Projects, Bug Report
chad closed T12752: Pager in Diffusion doesn't tell you what page you're on as Resolved.
Aug 6 2017, 2:51 AM · Design, Diffusion
chad closed T12752: Pager in Diffusion doesn't tell you what page you're on, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 6 2017, 2:51 AM · Design, Diffusion
chad closed T12763: Have custom icons made? Object + State? as Wontfix.
Aug 6 2017, 2:51 AM · Design
chad closed T11651: Owners empty states are lookin' weird as Resolved.

seems ok now.

Aug 6 2017, 2:50 AM · Owners, Design
chad closed T9868: PHUIDocumentViewPro ToC menu improvements as Resolved.
Aug 6 2017, 2:48 AM · PHUI
chad closed T9868: PHUIDocumentViewPro ToC menu improvements, a subtask of T9379: Build Phriction v3, as Resolved.
Aug 6 2017, 2:48 AM · Phriction
chad closed T12099: Implement caret as part of PHUIIconView as Resolved.

caret now appears when attaching dropdown menus to buttons.

Aug 6 2017, 2:47 AM · PHUI, Design
chad closed T10208: Document something about Design Feedback as Wontfix.
Aug 6 2017, 2:46 AM · Documentation, Design
chad closed T9974: Create PHUIObjectItemMiniView as Wontfix.
Aug 6 2017, 2:46 AM · PHUI
chad placed T5698: Github-style Remarkup previews on a checked-in resource up for grabs.
Aug 6 2017, 2:46 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
chad closed T12110: Persistent Chat UI broken-ish on clean install as Invalid.

Just launched a test instancepoo and everything seems fine.

Aug 6 2017, 2:44 AM · Conpherence (v4), Bug Report
chad closed T10032: Improve individual NUX states (application level) as Resolved.

Resolved enough.

Aug 6 2017, 2:42 AM · Modernization, NUX
chad added a revision to T12451: Finding your subscriptions / cards on Phacility is non-obvious: Unknown Object (Differential Revision).
Aug 6 2017, 2:42 AM · Phortune, Phacility
chad added a revision to T12952: Reviewer not able to see diff: Unknown Object (Differential Revision).
Aug 6 2017, 2:34 AM · Differential, Bug Report
joshuaspence added a comment to T12948: Remove the `bin/files purge` workflow.

I wonder if this OOM error can also be hit in other workflow though, given that it seems to occur in PhabricatorFileStorageEngine::getRawFileDataIterator.

Aug 6 2017, 1:28 AM · Bug Report, Files
joshuaspence added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

Yep, agreed that the re-targeted proposal is a better solution... I had just assumed that this was a documentation oversight.

Aug 6 2017, 12:15 AM · Bug Report, Files, Setup

Aug 5 2017

chad updated the task description for T4411: Adding a CC to a Maniphest Task should give View rights for that user.
Aug 5 2017, 9:16 PM · Wikimedia, Policy
chad claimed T12952: Reviewer not able to see diff.
Aug 5 2017, 9:14 PM · Differential, Bug Report
chad added a comment to T12952: Reviewer not able to see diff.

The plan forward here is to correct the text. I will follow up with you on Discourse.

Aug 5 2017, 9:00 PM · Differential, Bug Report
kugel- added a comment to T12952: Reviewer not able to see diff.

We require the "a revision's reviewers can always..." behavior. Please implement it instead of changing the text.

Aug 5 2017, 8:54 PM · Differential, Bug Report
epriestley added a comment to T12952: Reviewer not able to see diff.

D7150 added this text ("a revision's reviewers can always...") and I said it "wasn't true but would be soon", but never made it true.

Aug 5 2017, 7:07 PM · Differential, Bug Report
saggid edited the content of Community Resources.
Aug 5 2017, 4:09 PM
rfreebern added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: Unknown Object (Differential Revision).
Aug 5 2017, 2:15 PM · Dashboards
epriestley edited the content of Changelog.
Aug 5 2017, 10:45 AM
epriestley created 2017 Week 31 (Early August).
Aug 5 2017, 10:44 AM
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

remind me to add some more icons for Link.

Aug 5 2017, 12:51 AM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

That looks pretty hawt.

Aug 5 2017, 12:50 AM · Dashboards

Aug 4 2017

chad created T12952: Reviewer not able to see diff.
Aug 4 2017, 10:25 PM · Differential, Bug Report
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Happy to take a look if you found a reasonable way to get access to $request. If you're reading $_REQUEST['__path__'] directly or something though the eventual upstream version probably won't look too similar.

Aug 4 2017, 7:51 PM · Dashboards
rfreebern added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

I've written a patch to make this work for the project sidebar nav for my organization's install. I don't want to take up your time with it if it's not helpful, but let me know if you'd like me to push a diff.

Aug 4 2017, 7:36 PM · Dashboards
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 4 2017, 5:30 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 4 2017, 3:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 4 2017, 3:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
siepkes awarded T12813: Integrate Harbormaster with GoCD a Love token.
Aug 4 2017, 2:05 PM · Harbormaster, Feature Request
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 4 2017, 12:33 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

PHI27 is likely adjacent here.

Aug 4 2017, 11:40 AM · Restricted Project, Search
markusfluer added a revision to T12755: Aphlict doesn't work with the latest version of `ws`: Unknown Object (Differential Revision).
Aug 4 2017, 10:26 AM · Aphlict, Bug Report
• SamanthaNguyen removed a watcher for Wikimedia: • SamanthaNguyen.
Aug 4 2017, 4:00 AM
dp_blockparty awarded T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available a Like token.
Aug 4 2017, 2:30 AM · Haskell.org, Auth
dp_blockparty added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

I'd love to see support for U2F keys, as well.

Aug 4 2017, 2:29 AM · Haskell.org, Auth

Aug 3 2017

epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 9:37 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 7:39 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 7:20 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 6:41 PM · Phacility, Support
epriestley merged T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.
Aug 3 2017, 5:40 PM · Restricted Project, Macros, Files
epriestley merged task T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.
Aug 3 2017, 5:40 PM · Feature Request, Macros
epriestley added a comment to T12950: Regenerating thumbnails for memes is difficult.

I'm just going to merge this into T5258. There are two separate issues here:

Aug 3 2017, 5:40 PM · Feature Request, Macros
chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

This bug does exist on this server, but unclear why. Maybe related to size of image, but probably best solution is some command-line tool to regenerate all file transforms? I don't think making PHIDs easy to find inside the app is very user friendly.

Aug 3 2017, 5:31 PM · Feature Request, Macros
chad added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

fwiw, I can't reproduce this on OSX chrome any more. going to go test windows in german.... wish me glück.

Aug 3 2017, 4:42 PM · Restricted Project, Bug Report
epriestley renamed T12948: Remove the `bin/files purge` workflow from `bin/files purge` can run out of memory for large files to Remove the `bin/files purge` workflow.
Aug 3 2017, 2:53 PM · Bug Report, Files
epriestley added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

I retargeted this; I think the proposed solution is not the best solution we can find to the problem.

Aug 3 2017, 2:53 PM · Bug Report, Files, Setup
epriestley renamed T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource from CloudFront documentation should recommend forwarding query string to File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 3 2017, 2:52 PM · Bug Report, Files, Setup
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Doesn't look like the repository will even attempt to clone over HTTPS:

Aug 3 2017, 7:31 AM · Feature Request

Aug 2 2017

epriestley added a revision to T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index: Unknown Object (Differential Revision).
Aug 2 2017, 11:03 PM · Customer Impact, Search
joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros
chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

Why did they need regenerating in the first place?

Aug 2 2017, 9:38 PM · Feature Request, Macros
joshuaspence created T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 2 2017, 9:24 PM · Bug Report, Files, Setup
joshuaspence created T12950: Regenerating thumbnails for memes is difficult.
Aug 2 2017, 9:12 PM · Feature Request, Macros
epriestley added a comment to T5523: Make bulk moves easier on Workboards.

See Planning for information on progress and priorities.

Aug 2 2017, 6:02 PM · Restricted Project, Workboards
brianespinosa added a comment to T5523: Make bulk moves easier on Workboards.

Any progress on this issue? Agreed with @dariusz that this is my number one pet peeve. This is a pretty large omission from bulk editing capabilities for a column. I can set a task to move to a different column when I am commenting in a task. I'd expect the ability to do the same bulk process on a column of tasks, even if I could only move those tasks within the same workboard. Dragging and dropping tasks individually is extremely time consuming when I have to move tasks between columns.

Aug 2 2017, 5:24 PM · Restricted Project, Workboards
chad edited projects for T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one, added: Profile Menu Item; removed Workboards.
Aug 2 2017, 5:19 PM · Dashboards
brianespinosa awarded T5523: Make bulk moves easier on Workboards a Like token.
Aug 2 2017, 5:18 PM · Restricted Project, Workboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

This is an unusually low-tech solution but I can't think of any reasons why it won't work.

Aug 2 2017, 4:46 PM · Dashboards