Page MenuHomePhabricator

Support Pact Errata
Open, NormalPublic

Description

Just so I don't forget:

  • When you pay with a card after creating a pact, you get a spurious "invoice due" email when the invoice is generated.
  • InstancesSupportPact->voidInvoices() is a no-op stub.
  • Add an isUrgent flag to issues. Today, this would just make them red or something, eventually this will page oncall.

Maybe:

  • Add a description to Member so individuals can list their title / contact info / etc?

Done:

  • Add bucketing and filtering options to the "all issues" admin view, since this will be the support queue until we eventually outgrow it and do a Nuance backend.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
R25 Secure
D18223
D18222

Event Timeline

epriestley added a revision: Restricted Differential Revision.Jul 14 2017, 3:13 PM

Some stuff I'm thinking of doing in the short term:

  • Add an isUrgent flag to issues. Today, this would just make them red or something, eventually this will page oncall.
  • Add a isPinned flag to issues, maybe. I'm imagining pacts may have certain issues that we want to persist, like "List of legal documents", "current overall priorities", etc. Putting issues into a permanently open + pinned state might be a good catch-all for this, and if/when that breaks down we can build specific "Document Support" or "Priority List" features. Not totally sure we need this.
  • Add bucketing and filtering options to the "all issues" admin view, since this will be the support queue until we eventually outgrow it and do a Nuance backend.
  • Actually implement Mana.

Some other stuff:

  • We can use R25 to deploy a PHIxxx remarkup rule here on secure. It wouldn't do fancy hovercard/doorkeeper stuff but could at least auto-link which is probably a big chunk of the value.
  • Likewise, I think we can deploy a replacement Txxx rule on admin so Txxx links here by default (since admin does not install Maniphest). Not perfect but should be better than nothing.

Ideas, not sure if they're important:

  • Add a description to Member so individuals can list their title / contact info / etc?
epriestley added a commit: Restricted Diffusion Commit.Jul 14 2017, 3:25 PM

Email replies don't actually work since mail gets routed to the web tier (mail.phacililty.com) which can't hit admin. I think I can fix this with a mail route.

Test mail from the console now gets routed/accepted properly but real mail still doesn't. I'm going to write this off as possibly being a route propagation issue for a little bit and see if it fixes itself.

epriestley added a revision: Restricted Differential Revision.Jul 14 2017, 3:52 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.

Using @mentions in issue comments hits a policy exception because of the slightly odd way pact policy filtering works.

epriestley added a revision: Restricted Differential Revision.Jul 14 2017, 7:04 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 14 2017, 8:32 PM
epriestley added a commit: Restricted Diffusion Commit.

Inbound mail later bounced. I think the issue is that we have a *.phacility.com MX record, but an admin.phacility.com A record. I can't recite all the wildcard vs nonwildcard DNS rules offhand, but I think the A record is shadowing the MX record, e.g. dig mx admin.phacility.com does not produce the right results. I've added an admin.phacilty.com MX record which might sort things out once it propagates.

Inbound mail seems to be working now.

Screen Shot 2017-07-17 at 7.17.05 AM.png (145×799 px, 21 KB)

Two outstanding issues:

  • (PHI7) Outbound mail isn't working correctly for non-staff, I think it's getting caught in policy filtering.
  • (PHI5) Minor state transition when resolving open issues.
epriestley added a revision: Restricted Differential Revision.Jul 18 2017, 2:51 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 18 2017, 3:01 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 18 2017, 3:28 PM
epriestley added a revision: Restricted Differential Revision.Jul 18 2017, 6:37 PM
epriestley added a revision: Restricted Differential Revision.Jul 18 2017, 7:40 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 18 2017, 8:29 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 18 2017, 8:34 PM
epriestley added a revision: Restricted Differential Revision.Jul 19 2017, 2:34 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 19 2017, 6:03 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jul 19 2017, 6:05 PM
epriestley added a revision: Restricted Differential Revision.Jul 19 2017, 7:22 PM
epriestley added a revision: Restricted Differential Revision.Jul 19 2017, 8:43 PM
epriestley added a revision: Restricted Differential Revision.Jul 19 2017, 10:34 PM
epriestley added a revision: Restricted Differential Revision.Jul 19 2017, 10:51 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 19 2017, 11:01 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jul 19 2017, 11:04 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jul 19 2017, 11:12 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jul 20 2017, 9:33 PM
epriestley added a revision: Restricted Differential Revision.Jul 20 2017, 10:07 PM
epriestley added a revision: Restricted Differential Revision.
epriestley added a revision: Restricted Differential Revision.Jul 20 2017, 10:27 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 20 2017, 10:49 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jul 20 2017, 10:51 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jul 21 2017, 11:35 AM
epriestley added a revision: Restricted Differential Revision.Jul 21 2017, 2:38 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 21 2017, 5:13 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Jul 21 2017, 9:41 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 21 2017, 9:45 PM
epriestley added a revision: Restricted Differential Revision.Jul 26 2017, 5:50 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 26 2017, 6:51 PM
epriestley added a commit: Restricted Diffusion Commit.Jul 26 2017, 7:23 PM
epriestley added a revision: Restricted Differential Revision.Aug 3 2017, 6:41 PM
epriestley added a revision: Restricted Differential Revision.Aug 3 2017, 7:20 PM
epriestley added a revision: Restricted Differential Revision.Aug 3 2017, 7:39 PM
epriestley added a revision: Restricted Differential Revision.Aug 3 2017, 9:37 PM
epriestley added a commit: Restricted Diffusion Commit.Aug 3 2017, 9:47 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.Aug 3 2017, 9:55 PM
epriestley added a commit: Restricted Diffusion Commit.Aug 3 2017, 9:57 PM
epriestley added a revision: Restricted Differential Revision.Sep 28 2017, 12:27 AM
epriestley added a commit: Restricted Diffusion Commit.Sep 28 2017, 7:59 PM