Page MenuHomePhabricator
Create Task
Maniphest T12755

Aphlict doesn't work with the latest version of `ws`
Closed, ResolvedPublic
Actions

Description

It seems that Aphlict doesn't work with version 3 of [[https://www.npmjs.com/package/ws | ws]]:

<<< UNCAUGHT EXCEPTION! >>>

TypeError: Cannot read property 'url' of undefined
    at WebSocketServer.<anonymous> (/usr/local/src/phabricator/support/aphlict/server/lib/AphlictClientServer.js:96:43)
    at emitTwo (events.js:106:13)
    at WebSocketServer.emit (events.js:191:7)
    at handleUpgrade (/usr/local/src/phabricator/support/aphlict/server/node_modules/ws/lib/WebSocketServer.js:88:16)
    at WebSocketServer.completeUpgrade (/usr/local/src/phabricator/support/aphlict/server/node_modules/ws/lib/WebSocketServer.js:270:5)
    at WebSocketServer.handleUpgrade (/usr/local/src/phabricator/support/aphlict/server/node_modules/ws/lib/WebSocketServer.js:197:10)
    at Server.WebSocketServer._ultron.on (/usr/local/src/phabricator/support/aphlict/server/node_modules/ws/lib/WebSocketServer.js:87:14)
    at emitThree (events.js:116:13)
    at Server.emit (events.js:194:7)
    at onParserExecuteCommon (_http_server.js:409:14)

The problem is that we are accessing ws.upgradeReq, which has been removed. See the following upstream resources:

Revisions and Commits

rP Phabricator
Needs ReviewD18338 Fixed issue: Due to API change of WebSockets event callback had to be changed
D18411rP3b14c1fdd1cf Update AphlictClientServer to support ws2 or ws3

Related Objects

Event Timeline

joshuaspence created this task.May 25 2017, 12:45 AM
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Aphlict.
hele added a subscriber: hele.May 25 2017, 12:53 PM
This comment was removed by hele.
epriestley added a subscriber: epriestley.May 25 2017, 5:43 PM

See also vaguely related T12171.

cspeckmim added a subscriber: cspeckmim.May 26 2017, 3:23 AM
NDKilla mentioned this in Z1336: General Chat.May 30 2017, 2:43 PM
NDKilla added a subscriber: NDKilla.May 30 2017, 2:50 PM

This is kind of time-specific since it has a version number, but I got Aphlict working on my server by navigating to phabricator/support/aphlict/server and running npm install ws@2.X (literal X) as root. This installed version 2.3.1 (im assuming the latest stable 2.X version). Upon restarting aphlict, the notifications work without raising exceptions.

isfs added a subscriber: isfs.Jun 14 2017, 3:59 PM
shuLhan added a subscriber: shuLhan.Jul 12 2017, 2:49 PM
markusfluer added a revision: D18338: Fixed issue: Due to API change of WebSockets event callback had to be changed.Aug 4 2017, 10:26 AM
nickhutchinson added a subscriber: nickhutchinson.Aug 11 2017, 8:11 AM
chad added a revision: D18411: Update AphlictClientServer to support ws2 or ws3.Aug 11 2017, 10:03 PM
epriestley mentioned this in D18411: Update AphlictClientServer to support ws2 or ws3.Aug 11 2017, 10:12 PM
chad closed this task as Resolved by committing rP3b14c1fdd1cf: Update AphlictClientServer to support ws2 or ws3.Aug 11 2017, 10:17 PM
chad added a commit: rP3b14c1fdd1cf: Update AphlictClientServer to support ws2 or ws3.
Phabricator · Built by Phacility