Page MenuHomePhabricator
Feed All Stories

Aug 12 2020

kuba-orlik requested review of D21445: Change sshd templates so they use the new ssh-auth syntax.
Aug 12 2020, 7:04 PM
epriestley requested review of D21444: Remove "bin/repository lookup-users" workflow.
Aug 12 2020, 7:03 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21444: Remove "bin/repository lookup-users" workflow.
Aug 12 2020, 7:02 PM · Differential
epriestley requested review of D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Aug 12 2020, 6:43 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Aug 12 2020, 6:41 PM · Differential
epriestley requested review of D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Aug 12 2020, 6:33 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Aug 12 2020, 6:32 PM · Differential
epriestley requested review of D21441: Delete some commit dead parsing code.
Aug 12 2020, 4:32 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21441: Delete some commit dead parsing code.
Aug 12 2020, 4:31 PM · Differential
Harbormaster failed to build B24842: rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and… for rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and…!
Aug 12 2020, 4:08 PM
Harbormaster failed to build B24841: rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view for rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view!
Aug 12 2020, 4:07 PM
epriestley committed rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys (authored by epriestley).
Require rows passed to "loadAllFromArray()" have unique keys
Aug 12 2020, 4:05 PM
epriestley added a reverting change for D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly: rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys.
Aug 12 2020, 4:05 PM
epriestley closed D21400: Require rows passed to "loadAllFromArray()" have unique keys.
Aug 12 2020, 4:05 PM
epriestley committed rP429543b6376f: Fix some content/background overflow issues with commit graph lists (authored by epriestley).
Fix some content/background overflow issues with commit graph lists
Aug 12 2020, 4:04 PM
epriestley committed rP0b64092d25d0: Improve handle/status list display on devices in commit graph lists (authored by epriestley).
Improve handle/status list display on devices in commit graph lists
Aug 12 2020, 4:04 PM
epriestley committed rP49af92e90325: Improve commit action item layout on mobile (authored by epriestley).
Improve commit action item layout on mobile
Aug 12 2020, 4:04 PM
epriestley closed D21440: Fix some content/background overflow issues with commit graph lists.
Aug 12 2020, 4:04 PM
epriestley closed D21431: Improve handle/status list display on devices in commit graph lists.
Aug 12 2020, 4:04 PM
epriestley closed D21430: Improve commit action item layout on mobile.
Aug 12 2020, 4:04 PM
epriestley committed rP57f9450bcfc0: Improve desktop and mobile layouts for new "CommitGridView" (authored by epriestley).
Improve desktop and mobile layouts for new "CommitGridView"
Aug 12 2020, 4:04 PM
epriestley committed rP8aec3f916b39: Unify more build, property, auditor, and status information into… (authored by epriestley).
Unify more build, property, auditor, and status information into…
Aug 12 2020, 4:04 PM
epriestley closed D21418: Improve desktop and mobile layouts for new "CommitGridView".
Aug 12 2020, 4:04 PM
epriestley closed D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Aug 12 2020, 4:04 PM
epriestley triaged T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate as Low priority.
Aug 12 2020, 4:02 PM · Arcanist
epriestley committed rP36dac46ff263: Clean up some minor commit list CSS (authored by epriestley).
Clean up some minor commit list CSS
Aug 12 2020, 4:00 PM
epriestley closed D21416: Clean up some minor commit list CSS.
Aug 12 2020, 4:00 PM
epriestley committed rP57ee6649aa3f: Remove "PhabricatorAuditListView" (authored by epriestley).
Remove "PhabricatorAuditListView"
Aug 12 2020, 4:00 PM
epriestley closed D21415: Remove "PhabricatorAuditListView".
Aug 12 2020, 4:00 PM
epriestley committed rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView" (authored by epriestley).
Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
Aug 12 2020, 4:00 PM
epriestley closed D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Aug 12 2020, 4:00 PM
epriestley committed rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView" (authored by epriestley).
Move the view of merged changes to "DiffusionCommitGraphView"
Aug 12 2020, 4:00 PM
epriestley closed D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Aug 12 2020, 3:59 PM
epriestley committed rPcd09ba5e19d7: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView" (authored by epriestley).
Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Aug 12 2020, 3:59 PM
epriestley closed D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Aug 12 2020, 3:59 PM
epriestley committed rP9fa25253844e: Improve rendering of history graph in "CommitGraphView" (authored by epriestley).
Improve rendering of history graph in "CommitGraphView"
Aug 12 2020, 3:59 PM
epriestley committed rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and… (authored by epriestley).
Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and…
Aug 12 2020, 3:59 PM
epriestley closed D21411: Improve rendering of history graph in "CommitGraphView".
Aug 12 2020, 3:59 PM
epriestley closed D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Aug 12 2020, 3:59 PM
epriestley committed rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view (authored by epriestley).
Remove the "Graph" view as a dedicated repository view
Aug 12 2020, 3:59 PM
epriestley closed D21409: Remove the "Graph" view as a dedicated repository view.
Aug 12 2020, 3:59 PM
epriestley committed rP9afc5c628757: Remove "Recent Commits" from repository landing page (authored by epriestley).
Remove "Recent Commits" from repository landing page
Aug 12 2020, 3:59 PM
epriestley closed D21408: Remove "Recent Commits" from repository landing page.
Aug 12 2020, 3:59 PM
epriestley committed rPc8a279957dc1: Remove "DiffusionTagTableView" (authored by epriestley).
Remove "DiffusionTagTableView"
Aug 12 2020, 3:59 PM
epriestley closed D21407: Remove "DiffusionTagTableView".
Aug 12 2020, 3:59 PM
epriestley committed rP60e9f641907a: Remove the "authored" subheader from commits (authored by epriestley).
Remove the "authored" subheader from commits
Aug 12 2020, 3:59 PM
epriestley closed D21406: Remove the "authored" subheader from commits.
Aug 12 2020, 3:58 PM
epriestley committed rP7fd6bf26a949: Modernize "Author" and "Committer" rendering for commits (authored by epriestley).
Modernize "Author" and "Committer" rendering for commits
Aug 12 2020, 3:58 PM
epriestley closed D21405: Modernize "Author" and "Committer" rendering for commits.
Aug 12 2020, 3:58 PM
epriestley committed rP81e4e5b7f9c9: Remove construction of "author" information from "LastModified" payload in… (authored by epriestley).
Remove construction of "author" information from "LastModified" payload in…
Aug 12 2020, 3:58 PM
epriestley closed D21404: Remove construction of "author" information from "LastModified" payload in Diffusion.
Aug 12 2020, 3:58 PM
epriestley requested review of D21440: Fix some content/background overflow issues with commit graph lists.
Aug 12 2020, 3:57 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21440: Fix some content/background overflow issues with commit graph lists.
Aug 12 2020, 3:54 PM · Differential
arichardson abandoned D21438: Find the per-worktree .git directory when using git-worktree.
Aug 12 2020, 2:48 PM
epriestley committed rP545417597322: Coerce Chrome into breaking monospaced text when printing tables to PDFs (authored by epriestley).
Coerce Chrome into breaking monospaced text when printing tables to PDFs
Aug 12 2020, 2:35 PM
epriestley closed D21439: Coerce Chrome into breaking monospaced text when printing tables to PDFs.
Aug 12 2020, 2:35 PM
epriestley added a comment to D21438: Find the per-worktree .git directory when using git-worktree.

To be completely clear: I'm not going to accept any features upstream which zero customers are interested in. It doesn't matter if they're simple or complicated. If no customers want it, it isn't coming upstream.

Aug 12 2020, 2:17 PM
arichardson added a comment to D21438: Find the per-worktree .git directory when using git-worktree.

I don't expect any sophisticated git-worktree support. This is a simple change that allows arc get-config/set-config to work correctly when invoked from a worktree. It might also fix some other cases where arc expects $identity->localMetaDir to be a directory which previously wasn't the case for worktrees.

Aug 12 2020, 9:48 AM

Aug 11 2020

epriestley triaged T13567: Arcanist does not decode unicode filenames in Git before passing them to linters as Low priority.
Aug 11 2020, 6:38 PM · Arcanist
epriestley renamed T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits from Improve fallback behavior for "arc branches/bookmarks" to Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits as Normal priority.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13565: Filesystem write failure error messages lack tailoring, notably in DeferredLog as Normal priority.
Aug 11 2020, 6:04 PM · Infrastructure
epriestley requested review of D21439: Coerce Chrome into breaking monospaced text when printing tables to PDFs.
Aug 11 2020, 5:52 PM
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Aug 11 2020, 5:47 PM · Windows, Arcanist
epriestley added a comment to T13564: Remarkup tables should show all content when printed to PDF.

Adding overflow-wrap: anywhere appears to fix this without breaking anything.

Aug 11 2020, 5:35 PM · Google Chrome, Remarkup
epriestley triaged T13564: Remarkup tables should show all content when printed to PDF as Normal priority.
Aug 11 2020, 5:17 PM · Google Chrome, Remarkup
epriestley triaged T13563: On Windows, Arcanist tries and fails to set stdin nonblocking while reading the stream as Low priority.
Aug 11 2020, 5:06 PM · Windows, Arcanist
epriestley triaged T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions as Normal priority.
Aug 11 2020, 5:02 PM · Windows, Arcanist
epriestley added a revision to T9924: Add support for git worktree: D21438: Find the per-worktree .git directory when using git-worktree.
Aug 11 2020, 4:45 PM · FreeBSD, Restricted Project, Arcanist, Feature Request
epriestley added a task to D21438: Find the per-worktree .git directory when using git-worktree: T9924: Add support for git worktree.
Aug 11 2020, 4:45 PM
epriestley added a comment to D21438: Find the per-worktree .git directory when using git-worktree.

There's currently no customer interest in worktree support. The use cases in T9924 seem flimsy to me so I don't currently plan to support worktrees in the absence of customer interest. See also ArcanistGitWorkingCopy.

Aug 11 2020, 4:44 PM
arichardson updated the diff for D21438: Find the per-worktree .git directory when using git-worktree.
  • fix $vcs -> $vcs_type
Aug 11 2020, 3:54 PM
arichardson requested review of D21438: Find the per-worktree .git directory when using git-worktree.
Aug 11 2020, 3:52 PM
epriestley updated the task description for T13561: Allow the daemons to generate tasks dynamically at runtime.
Aug 11 2020, 3:26 PM · Daemons
epriestley triaged T13561: Allow the daemons to generate tasks dynamically at runtime as Normal priority.
Aug 11 2020, 3:15 PM · Daemons
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1816 would also like dimensional coverage: coverage by language; coverage by team/owner. This is perhaps worth considering in how coverage is aggregated.

Aug 11 2020, 2:54 PM · Diffusion, Plans
epriestley triaged T11372: Multiple coverage columns for different types of code coverage as Wishlist priority.
Aug 11 2020, 2:49 PM · Diffusion, Restricted Project
epriestley updated the task description for T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:48 PM · Diffusion, Plans
epriestley added subtasks for T13125: Plans: Code coverage reporting: T11372: Multiple coverage columns for different types of code coverage, T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Aug 11 2020, 2:47 PM · Diffusion, Plans
epriestley added a parent task for T9524: Show aggregate subdirectory coverage in Diffusion browse views: T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:47 PM · Diffusion, Restricted Project
epriestley added a parent task for T11372: Multiple coverage columns for different types of code coverage: T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:47 PM · Diffusion, Restricted Project

Aug 10 2020

epriestley committed rP79375c6c5398: Make "Quote" work properly in Pholio (authored by epriestley).
Make "Quote" work properly in Pholio
Aug 10 2020, 8:40 PM
epriestley closed D21437: Make "Quote" work properly in Pholio.
Aug 10 2020, 8:40 PM
epriestley triaged T13560: "Large number of changes" transaction timeline banner may hide a single change as Wishlist priority.
Aug 10 2020, 8:38 PM · Design
epriestley requested review of D21437: Make "Quote" work properly in Pholio.
Aug 10 2020, 8:33 PM
epriestley added a project to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: Accessibility.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting as Wishlist priority.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13558: Duration computation on user profiles is silly as Wishlist priority.
Aug 10 2020, 8:15 PM · Design

Aug 8 2020

epriestley edited the content of Changelog.
Aug 8 2020, 2:39 AM
epriestley committed rP5e3768473711: (stable) Promote 2020 Week 31 (authored by epriestley).
(stable) Promote 2020 Week 31
Aug 8 2020, 2:38 AM
epriestley created an object: 2020 Week 31 (Early August).
Aug 8 2020, 2:38 AM

Aug 5 2020

epriestley committed rPce0dc9a2ba2c: Correct an apparent off-by-one error when adjusting inlines across revision… (authored by epriestley).
Correct an apparent off-by-one error when adjusting inlines across revision…
Aug 5 2020, 8:13 PM
epriestley committed rPdbdfac1e072e: Recover inline comments which are "adjusted" off the end of a diff (authored by epriestley).
Recover inline comments which are "adjusted" off the end of a diff
Aug 5 2020, 8:13 PM
epriestley closed D21436: Correct an apparent off-by-one error when adjusting inlines across revision changes.
Aug 5 2020, 8:12 PM
epriestley closed D21435: Recover inline comments which are "adjusted" off the end of a diff.
Aug 5 2020, 8:12 PM
epriestley requested review of D21436: Correct an apparent off-by-one error when adjusting inlines across revision changes.
Aug 5 2020, 8:11 PM
epriestley requested review of D21435: Recover inline comments which are "adjusted" off the end of a diff.
Aug 5 2020, 8:01 PM
epriestley committed rP2db1955159f7: In Jupyter notebooks, read strings stored in the raw as either "string" or… (authored by epriestley).
In Jupyter notebooks, read strings stored in the raw as either "string" or…
Aug 5 2020, 7:26 PM
epriestley closed D21434: In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently.
Aug 5 2020, 7:26 PM
epriestley updated the task description for T13241: Guide: SMS is Insecure.
Aug 5 2020, 7:22 PM · Security, Guides