Page MenuHomePhabricator

Recover inline comments which are "adjusted" off the end of a diff
ClosedPublic

Authored by epriestley on Aug 5 2020, 7:59 PM.
Tags
None
Referenced Files
F14842873: D21435.id51006.diff
Sun, Feb 2, 2:28 AM
Unknown Object (File)
Mon, Jan 27, 4:23 PM
Unknown Object (File)
Sat, Jan 25, 8:35 AM
Unknown Object (File)
Sat, Jan 25, 8:35 AM
Unknown Object (File)
Sat, Jan 25, 8:35 AM
Unknown Object (File)
Sat, Jan 25, 8:35 AM
Unknown Object (File)
Tue, Jan 21, 1:00 PM
Unknown Object (File)
Sat, Jan 18, 6:43 PM
Subscribers
None

Details

Summary

See PHI1834. Currently, the inline adjustment engine can sometime "adjust" an inline off the end of a diff. If it does, we lay it out on an invalid display line here and never render it.

Instead, make sure that layout never puts a comment on an invalid line, so the UI is robust against questionable decisions by the adjustment engine: no adjustment should be able to accidentally discard an inline.

Test Plan
  • Created a two diff revision, where Diffs 1 and 2 have "alphabet.txt" with A-Z on one line each. The file is unchanged across diffs; some other file is changed.
  • Added a comment to lines P-Z of Diff 1.
  • Before: comment is adjusted out of range on Diff 2 and not shown in the UI.
  • After: comment is still adjusted out of range internally, but now corrected into the display range and shown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable