Page MenuHomePhabricator

In Jupyter notebooks, read strings stored in the raw as either "string" or "list<string>" more consistently
ClosedPublic

Authored by epriestley on Aug 5 2020, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 3, 1:43 PM
Unknown Object (File)
Apr 12 2025, 10:31 PM
Unknown Object (File)
Apr 10 2025, 9:52 AM
Unknown Object (File)
Apr 5 2025, 9:44 PM
Unknown Object (File)
Mar 30 2025, 11:17 AM
Unknown Object (File)
Mar 27 2025, 2:42 PM
Unknown Object (File)
Mar 24 2025, 11:24 PM
Unknown Object (File)
Mar 23 2025, 10:27 AM
Subscribers
None

Details

Summary

Ref PHI1835. Generally, Jupyter notebooks in the wild may store source and markdown content as either a single string or a list of strings.

Make the renderer read these formats more consistently. In particular, this fixes rendering of code blocks stored as a single string.

This also fixes an issue where cell labels were double-rendered in diff views.

Test Plan

Created a notebook with a code block represented on disk as a single string, rendered a diff from it.

Screen Shot 2020-08-05 at 12.18.44 PM.png (149×1 px, 48 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2020, 7:26 PM
This revision was automatically updated to reflect the committed changes.