Page MenuHomePhabricator
Feed All Stories

Jul 8 2019

epriestley committed rPHUb416093386a2: Improve coverage of remarkup "<table>" rule and fix some bad method calls (authored by epriestley).
Improve coverage of remarkup "<table>" rule and fix some bad method calls
Jul 8 2019, 11:57 PM
epriestley closed D20644: Improve coverage of remarkup "<table>" rule and fix some bad method calls.
Jul 8 2019, 11:57 PM
epriestley added a comment to D20644: Improve coverage of remarkup "<table>" rule and fix some bad method calls.

I'm going to fast-track this to production since the fatal in PHI1334 is particularly unlucky (repository landing page) and I'm pretty confident the change doesn't make anything worse.

Jul 8 2019, 11:56 PM
epriestley requested review of D20644: Improve coverage of remarkup "<table>" rule and fix some bad method calls.
Jul 8 2019, 11:55 PM
epriestley committed rPHUbda42d11c2c7: (stable) When parsing HTML in remarkup, always start a new tag when… (authored by epriestley).
(stable) When parsing HTML in remarkup, always start a new tag when…
Jul 8 2019, 11:41 PM
epriestley committed rPHU1a9220ba378b: (stable) Fix some remarkup issues with selective construction of child nodes… (authored by epriestley).
(stable) Fix some remarkup issues with selective construction of child nodes…
Jul 8 2019, 11:41 PM
epriestley updated the task description for T11036: Put subproject columns on workboards.
Jul 8 2019, 11:20 PM · Workboards (v3), Projects (v3)
joshuaspence abandoned D20643: Allow daemons to be run in the foreground.
Jul 8 2019, 6:20 PM
epriestley updated subscribers of T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

@20after4, any chance there's a stack trace for this in the webserver error logs? I can't immediately figure out how to reproduce this locally.

Jul 8 2019, 3:57 PM · Javelin
epriestley requested changes to D20643: Allow daemons to be run in the foreground.

We don't have any customer use cases for this so I'm not interested in bringing it upstream at this time.

Jul 8 2019, 3:10 PM
joshuaspence requested review of D20643: Allow daemons to be run in the foreground.
Jul 8 2019, 3:02 AM

Jul 6 2019

aklapper created T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 6 2019, 9:37 AM · Javelin

Jul 5 2019

amckinley committed rP3c4322252513: Fix paging fatal with flagged objects (authored by amckinley).
Fix paging fatal with flagged objects
Jul 5 2019, 9:25 PM
amckinley closed D20642: Fix paging fatal with flagged objects.
Jul 5 2019, 9:25 PM
amckinley closed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()" as Resolved by committing rP3c4322252513: Fix paging fatal with flagged objects.
Jul 5 2019, 9:25 PM · Flags
epriestley accepted D20642: Fix paging fatal with flagged objects.
Jul 5 2019, 5:17 PM

Jul 4 2019

amckinley requested review of D20642: Fix paging fatal with flagged objects.
Jul 4 2019, 11:03 PM
amckinley added a comment to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".

Thanks for the report. Fixed in D20642, which may or may not land today because of the holiday.

Jul 4 2019, 11:02 PM · Flags
amckinley added a revision to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()": D20642: Fix paging fatal with flagged objects.
Jul 4 2019, 11:01 PM · Flags
amckinley claimed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 10:40 PM · Flags
epriestley committed rP45f421154179: Fix URI escaping, which should actually be "%s", not "%p" (authored by epriestley).
Fix URI escaping, which should actually be "%s", not "%p"
Jul 4 2019, 6:02 PM
aklapper created T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 2:49 PM · Flags
amckinley added a comment to D20641: Add ferret support to Slowvote.

But we could also do it later.

Jul 4 2019, 1:37 AM

Jul 3 2019

epriestley accepted D20641: Add ferret support to Slowvote.

You can also follow 20190412.herald.01.rebuild.php to add a migration which queues a worker to queue other workers to rebuild the index now. It's probably reasonable to do for Slowvote since installs are unlikely to have millions upon millions of these. But we could also do it later.

Jul 3 2019, 11:20 PM
amckinley requested review of D20641: Add ferret support to Slowvote.
Jul 3 2019, 11:17 PM
20after4 awarded T11036: Put subproject columns on workboards a Love token.
Jul 3 2019, 11:03 PM · Workboards (v3), Projects (v3)
epriestley committed rP02315c4c48b9: Fix double-close on dialogs leading to Javascript console error (authored by epriestley).
Fix double-close on dialogs leading to Javascript console error
Jul 3 2019, 7:39 PM
epriestley closed D20640: Fix double-close on dialogs leading to Javascript console error.
Jul 3 2019, 7:38 PM
amckinley accepted D20640: Fix double-close on dialogs leading to Javascript console error.
Jul 3 2019, 6:57 PM
epriestley added a comment to T4900: Workboards updating in real time.

Just thinking out loud:

Jul 3 2019, 5:54 PM · Workboards (v3), User Delight, Wikimedia
epriestley updated the diff for D20639: Make pressing "R" on your keyboard reload the card state on workboards.
  • Remove debugging code.
  • Fix "oui oui".
Jul 3 2019, 5:14 PM
epriestley committed rPfc795994f30f: Remove obsolete "options" from workboard "updateCard()" call (authored by epriestley).
Remove obsolete "options" from workboard "updateCard()" call
Jul 3 2019, 5:06 PM
epriestley closed D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 3 2019, 5:06 PM
epriestley committed rP2de8a23adb09: Remove remnants of clumsy old URI state handling from workboards (authored by epriestley).
Remove remnants of clumsy old URI state handling from workboards
Jul 3 2019, 5:05 PM
epriestley closed D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 3 2019, 5:05 PM
epriestley committed rP58e2fa0d47fd: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..."… (authored by epriestley).
Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..."…
Jul 3 2019, 5:02 PM
epriestley closed D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 3 2019, 5:02 PM
epriestley closed T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board) as Resolved by committing rP58e2fa0d47fd: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..."….
Jul 3 2019, 5:02 PM · Workboards
epriestley requested review of D20640: Fix double-close on dialogs leading to Javascript console error.
Jul 3 2019, 3:20 PM
epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: D20640: Fix double-close on dialogs leading to Javascript console error.
Jul 3 2019, 3:19 PM · Quicksand

Jul 2 2019

epriestley added inline comments to D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 11:46 PM
amckinley accepted D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 11:31 PM
amckinley accepted D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 2 2019, 10:57 PM
amckinley accepted D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 10:56 PM
amckinley accepted D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 10:38 PM
epriestley committed rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller (authored by epriestley).
Move workboard "Move Tasks to Column..." workflow to a separate controller
Jul 2 2019, 10:16 PM
epriestley closed D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 10:16 PM
epriestley committed rPec352b1b31bb: Move workboard "Bulk Edit Tasks" workflow to a separate controller (authored by epriestley).
Move workboard "Bulk Edit Tasks" workflow to a separate controller
Jul 2 2019, 10:04 PM
epriestley closed D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 10:04 PM
epriestley committed rP9ea7227f0fc9: Move workboard "View as Query" workflow to a separate controller (authored by epriestley).
Move workboard "View as Query" workflow to a separate controller
Jul 2 2019, 10:00 PM
epriestley closed D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 10:00 PM
amckinley accepted D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 9:57 PM
epriestley committed rP577020aea951: Move workboard "filter" workflow to a separate controller (authored by epriestley).
Move workboard "filter" workflow to a separate controller
Jul 2 2019, 9:39 PM
epriestley closed D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 9:39 PM
amckinley accepted D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 9:37 PM
epriestley committed rP9e096cd274b0: Give the workboard "default" workflows more modern state handling (authored by epriestley).
Give the workboard "default" workflows more modern state handling
Jul 2 2019, 9:36 PM
epriestley closed D20629: Give the workboard "default" workflows more modern state handling.
Jul 2 2019, 9:36 PM
epriestley committed rP9c190d68ed37: Separate workboard view state (ordering, filtering, hidden columns) from the… (authored by epriestley).
Separate workboard view state (ordering, filtering, hidden columns) from the…
Jul 2 2019, 9:34 PM
epriestley closed D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 9:34 PM
epriestley updated the diff for D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
  • Use "%p" in urisprintf().
Jul 2 2019, 9:32 PM
epriestley added inline comments to D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 9:30 PM
epriestley committed rPHU5fc88a5c73f1: When parsing HTML in remarkup, always start a new tag when encountering "<" (authored by epriestley).
When parsing HTML in remarkup, always start a new tag when encountering "<"
Jul 2 2019, 9:19 PM
epriestley closed D20631: When parsing HTML in remarkup, always start a new tag when encountering "<".
Jul 2 2019, 9:19 PM
epriestley committed rPHUeff4eb29ff48: Fix some remarkup issues with selective construction of child nodes after HTML… (authored by epriestley).
Fix some remarkup issues with selective construction of child nodes after HTML…
Jul 2 2019, 9:13 PM
epriestley closed D20630: Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing.
Jul 2 2019, 9:13 PM
epriestley requested review of D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 8:59 PM
epriestley added a revision to T4900: Workboards updating in real time: D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 2 2019, 8:58 PM · Workboards (v3), User Delight, Wikimedia
amckinley accepted D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 8:37 PM
amckinley accepted D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 8:35 PM
amckinley accepted D20630: Fix some remarkup issues with selective construction of child nodes after HTML DOM parsing.
Jul 2 2019, 7:25 PM
amckinley accepted D20629: Give the workboard "default" workflows more modern state handling.
Jul 2 2019, 7:13 PM
epriestley added inline comments to D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 7:02 PM
amckinley accepted D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 6:26 PM
amckinley updated the test plan for D20628: Separate workboard view state (ordering, filtering, hidden columns) from the View controller.
Jul 2 2019, 5:50 PM
epriestley updated the diff for D20638: Remove obsolete "options" from workboard "updateCard()" call.
  • For better or worse, there actually is an external caller in WorkboardController that slipped past me.
Jul 2 2019, 5:33 PM
amckinley added a comment to D20616: Make "PhutilProcessQuery" detection of overseer processes more robust.

It's turtles all the way down. Computers don't work and all conventions and toolsets are fundamentally broken:

Jul 2 2019, 5:31 PM
amckinley accepted D20631: When parsing HTML in remarkup, always start a new tag when encountering "<".
Jul 2 2019, 5:25 PM
epriestley requested review of D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 2 2019, 5:21 PM
epriestley added a revision to T4900: Workboards updating in real time: D20638: Remove obsolete "options" from workboard "updateCard()" call.
Jul 2 2019, 5:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

Here's roughly where I'm headed next. I'm planning to:

Jul 2 2019, 5:18 PM · Workboards (v3), User Delight, Wikimedia
epriestley added inline comments to D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 4:33 PM
epriestley added a comment to T4900: Workboards updating in real time.

The "default" controller currently needs to "force" the URI parameters...
The "filter" controller currently needs to "force" the URI parameters...
The "apply" flow, where a new custom filter is applied...

Jul 2 2019, 4:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 4:31 PM
epriestley added a revision to T4900: Workboards updating in real time: D20637: Remove remnants of clumsy old URI state handling from workboards.
Jul 2 2019, 4:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 3:34 PM
epriestley added a revision to T4900: Workboards updating in real time: D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 3:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.
Jul 2 2019, 3:32 PM · Workboards
epriestley requested review of D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 2:45 PM
epriestley added a revision to T4900: Workboards updating in real time: D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 2:43 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): D20635: Move workboard "Move Tasks to Column..." workflow to a separate controller.
Jul 2 2019, 2:43 PM · Workboards
epriestley added a comment to D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.

In D12475, the "bulk edit" (then, "batch edit") stuff was added originally. This included a "Batch Edit Visible Tasks..." action that brought you into an edit workflow for every visible task on the board.

Jul 2 2019, 1:25 PM
epriestley requested review of D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 1:18 PM
epriestley added a revision to T4900: Workboards updating in real time: D20634: Move workboard "Bulk Edit Tasks" workflow to a separate controller.
Jul 2 2019, 1:16 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 12:52 PM
epriestley added a revision to T4900: Workboards updating in real time: D20633: Move workboard "View as Query" workflow to a separate controller.
Jul 2 2019, 12:50 PM · Workboards (v3), User Delight, Wikimedia
epriestley added inline comments to D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 12:35 PM
epriestley requested review of D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 12:32 PM
epriestley added a revision to T4900: Workboards updating in real time: D20632: Move workboard "filter" workflow to a separate controller.
Jul 2 2019, 12:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley committed rP0ae9e2c75d1f: Remove property "id" from Workboard View controller (authored by epriestley).
Remove property "id" from Workboard View controller
Jul 2 2019, 12:17 PM
epriestley closed D20627: Remove property "id" from Workboard View controller.
Jul 2 2019, 12:17 PM