- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 18 2019
Jun 18 2019
epriestley committed rPdcf3ca8e0450: When a user clicks a navigation link in a dialog, close the dialog (authored by epriestley).
When a user clicks a navigation link in a dialog, close the dialog
epriestley committed rPdda5c13ef549: Parse "shallow" frames in the Git "upload-pack" wire protocol parser (authored by epriestley).
Parse "shallow" frames in the Git "upload-pack" wire protocol parser
epriestley added a comment to D20573: When a user clicks a navigation link in a dialog, close the dialog.
- Make it less so.
D20573: When a user clicks a navigation link in a dialog, close the dialog is now accepted and ready to land.
D20584: Replace weird, redundant list of branches in Diffusion "Manage" UI with a link to the main branch list is now accepted and ready to land.
D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser is now accepted and ready to land.
epriestley committed rP753828649956: Fix missing link targets for "View Object" header buttons in HTML email (authored by epriestley).
Fix missing link targets for "View Object" header buttons in HTML email
D20586: Fix missing link targets for "View Object" header buttons in HTML email is now accepted and ready to land.
epriestley committed rP6219d30f6b0b: Recommend dumping database backups with "--compress --output X" instead of "|… (authored by epriestley).
Recommend dumping database backups with "--compress --output X" instead of "|…
epriestley committed rP1dd62f79cedb: Fix more "msort()" vs "msortv()" callsites (authored by epriestley).
Fix more "msort()" vs "msortv()" callsites
epriestley committed rP731b45d81847: In "bin/repository reparse", continue on… (authored by epriestley).
In "bin/repository reparse", continue on…
epriestley updated subscribers of T13156: Plans: Improve Phacility UI for managing instance managers and cards.
See PHI954. The "support pact members" cache is currently updated only when you actually click "Support", but this is often silly and unintuitive.
D20572: Recommend dumping database backups with "--compress --output X" instead of "| gzip > X" is now accepted and ready to land.
D20588: In "bin/repository reparse", continue on "PhabricatorWorkerPermanentFailureException" is now accepted and ready to land.
epriestley renamed T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility) from Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility to Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility).
epriestley added a comment to T13317: Unverified/nonsense account emails can trigger inbound CCs (was: Inbound support pact email sometimes CCs disabled user `@maxhodges` in Phacility).
Aha! This user very cleverly added noreply@admin.phacility.com to their user account before they were disabled.
D20587: Fix more "msort()" vs "msortv()" callsites is now accepted and ready to land.
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
- Plus a rebase for the msortv() change.
Harbormaster failed remote builds in B22977: Diff 49102 for D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser!
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
🥾
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
Oh, not sure what happened there -- that's the local result, so maybe I ^C'd too fast. Let me just kick it...
amckinley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
Is it expected that B22956 never completed?
Jun 17 2019
Jun 17 2019
epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
I deployed that last round of things to secure. Not totally confident I got everything, but hopefully we're in better shape now.
epriestley committed rPaba7c98baedb: Skip loading transaction handles in an old migration (authored by epriestley).
Skip loading transaction handles in an old migration
epriestley committed rPbab35f28e49d: Respect repository identities when selecting author vs auditor actions (authored by epriestley).
Respect repository identities when selecting author vs auditor actions
epriestley committed rP4450c908818d: When triggering audits, respect committer identities when importing commits (authored by epriestley).
When triggering audits, respect committer identities when importing commits
epriestley committed rP4af73a625fe1: Don't require users be logged in to access the Logout controller, so users with… (authored by epriestley).
Don't require users be logged in to access the Logout controller, so users with…
epriestley added a comment to D20578: Don't require users be logged in to access the Logout controller, so users with no Spaces can log out.
- Rebase to pick up the unit test fix.
epriestley added a comment to D20578: Don't require users be logged in to access the Logout controller, so users with no Spaces can log out.
Explain the behavior more clearly -- there are three classes of users:
epriestley committed rP14b076578f8e: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes (authored by epriestley).
In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
D20578: Don't require users be logged in to access the Logout controller, so users with no Spaces can log out is now accepted and ready to land.
epriestley committed rP2bc045bab8d7: Fix another stray "msort()/msortv()" issue (authored by epriestley).
Fix another stray "msort()/msortv()" issue
D20585: Fix another stray "msort()/msortv()" issue is now accepted and ready to land.
epriestley added a comment to rP874282db7589: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after….
D20585 should resolve the build failure.
epriestley committed rP874282db7589: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after… (authored by epriestley).
Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after…
epriestley committed rPHUada64585035e: Consider "msort()" on "PhutilSortVector" objects to be an error (authored by epriestley).
Consider "msort()" on "PhutilSortVector" objects to be an error
D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes is now accepted and ready to land.
D20582: Consider "msort()" on "PhutilSortVector" objects to be an error is now accepted and ready to land.
D20581: Respect repository identities when selecting author vs auditor actions is now accepted and ready to land.
D20570: Skip loading transaction handles in an old migration is now accepted and ready to land.
D20583: Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes is now accepted and ready to land.
epriestley added a comment to T13296: PCRE segfaults after "fork()" on PHP 7.3+ on MacOS with "pcre.jit" enabled.
The change above seems to have worked around things, I'll leave this open until we can confirm that PHP 7.3.6 or some later version fixes the underlying issue.
epriestley committed rPd3112392d1e8: Allow "Sign with MFA" to be applied as a comment action without requiring… (authored by epriestley).
Allow "Sign with MFA" to be applied as a comment action without requiring…
epriestley requested review of D20582: Consider "msort()" on "PhutilSortVector" objects to be an error.
epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
uhoh looks like I'm a dum dum
epriestley added a comment to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.
This is doing somewhat better now, but I've still seen:
epriestley added a comment to D20577: Parse "shallow" frames in the Git "upload-pack" wire protocol parser.
In the Discourse thread (https://discourse.phabricator-community.org/t/how-to-have-a-shallow-git-mirror/2805/) the reporting user also reported that this patch worked in their (illegal, forbidden) use case.
D20580: When triggering audits, respect committer identities when importing commits is now accepted and ready to land.
D20574: Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT" is now accepted and ready to land.
epriestley requested review of D20581: Respect repository identities when selecting author vs auditor actions.
epriestley requested review of D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes.
epriestley added a comment to T13312: "Branch Status" in Diffusion has a bizarre pager at the top of the element.
If this table is retained, there's a mystery meat "branch" icon meaning "default branch" in the leftmost column. This should get a label/tip.