Page MenuHomePhabricator

When a user clicks a navigation link in a dialog, close the dialog
ClosedPublic

Authored by epriestley on Jun 6 2019, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 2, 6:04 PM
Unknown Object (File)
Wed, Jun 22, 10:58 AM
Unknown Object (File)
Tue, Jun 14, 1:41 PM
Unknown Object (File)
Thu, Jun 9, 1:50 PM
Unknown Object (File)
Jun 2 2022, 5:25 AM
Subscribers
None

Details

Summary

Ref T13302. Currently, if you enable Quicksand (by clicking "Persistent Chat"), open a dialog with links in it (like "Create Subtask" with multiple available subtypes), and then follow a navigation link, the page content reloads behind the dialog but the dialog stays in the foreground.

Fix this by closing dialogs when users click navigation links inside them.

Test Plan

With Quicksand enabled and disabled, clicked a subtask type in the "Create Subtask" dialog.

  • Before, Quicksand Disabled: Dialog stays on screen, then navigation occurs.
  • After, Quicksand Disabled: Dialog vanishes, then navigation occurs.
  • Before, Quicksand Enabled: Dialog stays on screen, navigation occurs behind it.
  • After, Quicksand Enabled: Dialog vanishes, then navigation occurs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
webroot/rsrc/externals/javelin/lib/Workflow.js
98

Needs less "so", I think.

This revision is now accepted and ready to land.Jun 18 2019, 9:49 PM