Page MenuHomePhabricator

When a user clicks a navigation link in a dialog, close the dialog
ClosedPublic

Authored by epriestley on Jun 6 2019, 1:50 AM.

Details

Summary

Ref T13302. Currently, if you enable Quicksand (by clicking "Persistent Chat"), open a dialog with links in it (like "Create Subtask" with multiple available subtypes), and then follow a navigation link, the page content reloads behind the dialog but the dialog stays in the foreground.

Fix this by closing dialogs when users click navigation links inside them.

Test Plan

With Quicksand enabled and disabled, clicked a subtask type in the "Create Subtask" dialog.

  • Before, Quicksand Disabled: Dialog stays on screen, then navigation occurs.
  • After, Quicksand Disabled: Dialog vanishes, then navigation occurs.
  • Before, Quicksand Enabled: Dialog stays on screen, navigation occurs behind it.
  • After, Quicksand Enabled: Dialog vanishes, then navigation occurs.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 6 2019, 1:50 AM
epriestley requested review of this revision.Jun 6 2019, 1:52 AM
amckinley accepted this revision.Jun 18 2019, 9:49 PM
amckinley added inline comments.
webroot/rsrc/externals/javelin/lib/Workflow.js
98

Needs less "so", I think.

This revision is now accepted and ready to land.Jun 18 2019, 9:49 PM
  • Make it less so.