Page MenuHomePhabricator

Fix more "msort()" vs "msortv()" callsites

Authored by epriestley on Jun 18 2019, 2:30 PM.



See The recent changes to turn msort() on a vector an error have smoked out a few more of these mistakes.

These cases do not meaningfully rely on sort stability so there's no real bug being fixed, but we'd still prefer msortv().

Test Plan

Viewed MFA and External Account settings panels. Did a git grep 'msort(' | grep -i vector for any more obvious callsites, but none turned up.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 18 2019, 2:30 PM
epriestley requested review of this revision.Jun 18 2019, 2:32 PM
amckinley accepted this revision.Jun 18 2019, 5:14 PM
This revision is now accepted and ready to land.Jun 18 2019, 5:14 PM
This revision was automatically updated to reflect the committed changes.