Page MenuHomePhabricator

Fix more "msort()" vs "msortv()" callsites
ClosedPublic

Authored by epriestley on Tue, Jun 18, 2:30 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/unhandled-exception-when-logging-in-with-mfa/2828. The recent changes to turn msort() on a vector an error have smoked out a few more of these mistakes.

These cases do not meaningfully rely on sort stability so there's no real bug being fixed, but we'd still prefer msortv().

Test Plan

Viewed MFA and External Account settings panels. Did a git grep 'msort(' | grep -i vector for any more obvious callsites, but none turned up.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Jun 18, 2:30 PM
epriestley requested review of this revision.Tue, Jun 18, 2:32 PM
amckinley accepted this revision.Tue, Jun 18, 5:14 PM
This revision is now accepted and ready to land.Tue, Jun 18, 5:14 PM
This revision was automatically updated to reflect the committed changes.