Page MenuHomePhabricator

Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:40 PM.

Details

Summary

Ref T13303. I upgraded this to a vector-based sort but forgot to type a "v", which means the sort has different stability under PHP 5.5. See D20582 for a root cause fix.

Test Plan

Locally, on PHP7, not much changes. I expect this to fix the odd selection of title stories in mail and notification stories on secure, which is running PHP 5.5.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 17 2019, 5:40 PM
epriestley requested review of this revision.Jun 17 2019, 5:42 PM
amckinley accepted this revision.Jun 17 2019, 7:05 PM
This revision is now accepted and ready to land.Jun 17 2019, 7:05 PM
epriestley edited the summary of this revision. (Show Details)Jun 17 2019, 7:05 PM