Page MenuHomePhabricator

Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT"
ClosedPublic

Authored by epriestley on Jun 6 2019, 2:23 AM.
Tags
None
Referenced Files
F15463616: D20574.diff
Wed, Apr 2, 1:32 AM
F15460756: D20574.id49089.diff
Tue, Apr 1, 1:56 AM
F15449873: D20574.id.diff
Fri, Mar 28, 12:36 PM
F15447192: D20574.diff
Thu, Mar 27, 10:24 PM
F15434953: D20574.id49089.diff
Tue, Mar 25, 6:10 AM
F15418804: D20574.diff
Fri, Mar 21, 1:35 AM
Unknown Object (File)
Feb 27 2025, 12:25 AM
Unknown Object (File)
Feb 18 2025, 9:52 AM
Subscribers
None

Details

Summary

Fixes T13307. We currently require "CAN_EDIT" to sign actions, but it's fine to sign a comment with only "CAN_INTERACT".

Since the actions like "Accept Revision" already work like this, the fix is one line.

Test Plan

Screen Shot 2019-06-05 at 7.21.16 PM.png (454×638 px, 34 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable