Page MenuHomePhabricator

Allow "Sign with MFA" to be applied as a comment action without requiring "CAN_EDIT"
ClosedPublic

Authored by epriestley on Thu, Jun 6, 2:23 AM.

Details

Summary

Fixes T13307. We currently require "CAN_EDIT" to sign actions, but it's fine to sign a comment with only "CAN_INTERACT".

Since the actions like "Accept Revision" already work like this, the fix is one line.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jun 6, 2:23 AM
epriestley requested review of this revision.Thu, Jun 6, 2:25 AM

Ignore this, test.

amckinley accepted this revision.Mon, Jun 17, 5:17 PM
This revision is now accepted and ready to land.Mon, Jun 17, 5:17 PM