Page MenuHomePhabricator

Recommend dumping database backups with "--compress --output X" instead of "| gzip > X"
ClosedPublic

Authored by epriestley on Jun 5 2019, 10:00 PM.
Tags
None
Referenced Files
F14805562: D20572.id49109.diff
Sat, Jan 25, 8:51 PM
F14797605: D20572.id49109.diff
Sat, Jan 25, 5:13 AM
F14797604: D20572.id49075.diff
Sat, Jan 25, 5:13 AM
F14797603: D20572.id.diff
Sat, Jan 25, 5:12 AM
Unknown Object (File)
Thu, Jan 23, 3:25 PM
Unknown Object (File)
Thu, Jan 23, 11:39 AM
Unknown Object (File)
Tue, Jan 21, 11:03 AM
Unknown Object (File)
Fri, Jan 17, 4:31 PM
Subscribers
None

Details

Summary

Fixes T13304. Shell pipes and redirects do not have robust behavior when errors occur. We provide "--compress" and "--output" flags as robust alternatives, but do not currently recommend their use.

  • Recommend their use, since their error handling behavior is more robust in the face of issues like full disks.
  • If "--compress" is provided but won't work because the "zlib" extension is missing, raise an explicit error. I believe this extension is very common and this error should be rare. If that turns out to be untrue, we could take another look at this.
  • Also, verify some flag usage sooner so we can exit with an error faster if you mistype a "bin/storage dump" command.
Test Plan

Read documentation, hit affected error cases, did a dump and spot-checked that it came out sane looking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable