Page MenuHomePhabricator

Skip loading transaction handles in an old migration
ClosedPublic

Authored by epriestley on Wed, Jun 5, 6:43 PM.

Details

Summary

Ref T13305. See that task for discussion.

This old migration may indirectly cause search index worker tasks to queue by loading handles. They'll fail since we later added dateCreated to the worker task table.

Use needHandles(false) (since we don't use them) to disable loading handles and avoid the problem.

Test Plan
  • Ran bin/storage upgrade -f on an older instance (late 2016) and hit this issue.
  • Applied the patch, got a clean migration to modernity.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jun 5, 6:43 PM
Owners added a subscriber: Restricted Owners Package.Wed, Jun 5, 6:43 PM
epriestley requested review of this revision.Wed, Jun 5, 6:44 PM
amckinley accepted this revision.Mon, Jun 17, 7:39 PM
This revision is now accepted and ready to land.Mon, Jun 17, 7:39 PM
This revision was automatically updated to reflect the committed changes.