HomePhabricator

Fix more "msort()" vs "msortv()" callsites

Description

Fix more "msort()" vs "msortv()" callsites

Summary:
See https://discourse.phabricator-community.org/t/unhandled-exception-when-logging-in-with-mfa/2828. The recent changes to turn msort() on a vector an error have smoked out a few more of these mistakes.

These cases do not meaningfully rely on sort stability so there's no real bug being fixed, but we'd still prefer msortv().

Test Plan: Viewed MFA and External Account settings panels. Did a git grep 'msort(' | grep -i vector for any more obvious callsites, but none turned up.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20587

Details

Provenance
epriestleyAuthored on Jun 18 2019, 2:27 PM
epriestleyPushed on Jun 18 2019, 6:36 PM
Reviewer
amckinley
Differential Revision
D20587: Fix more "msort()" vs "msortv()" callsites
Parents
rP731b45d81847: In "bin/repository reparse", continue on…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22983
Build 31545: Run Core Tests