Page MenuHomePhabricator

There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes
Open, LowPublic

Description

Symptoms:

  • Maniphest email is now showing transactions in reverse order (not sure this was up to date, though).
  • When a revision is accepted, the notification popup bubble now says "X is ready to land", not "alice accepted X".

Probable cause:

  • The "stablize sort in PHP 7" stuff probably missed an extra array_reverse() somewhere, since the old sort order was flipped? Or the new sort order is flipped?

Event Timeline

epriestley triaged this task as Low priority.
epriestley renamed this task from There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changs to There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes.Thu, May 30, 7:09 PM

D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

This is doing somewhat better now, but I've still seen:

  • Notifications for accepted commits are saying "Dxxx is ready to land", not "alice accepted X".
  • Task creation email sent out with [ Changed Policy ] or something instead of [ Created ].

Pretty sure these were both after rP81134d7e made it to secure so there's at least some more stuff to hunt down.

uhoh looks like I'm a dum dum