Page MenuHomePhabricator
Differential D20586

Fix missing link targets for "View Object" header buttons in HTML email
ClosedPublic
Actions

Authored by epriestley on Jun 18 2019, 2:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 10:25 PM
Unknown Object (File)
Mon, May 26, 10:21 PM
Unknown Object (File)
Mon, May 26, 9:50 PM
Unknown Object (File)
Sun, May 25, 9:24 PM
Unknown Object (File)
Apr 26 2025, 10:38 PM
Unknown Object (File)
Apr 24 2025, 9:47 PM
Unknown Object (File)
Apr 19 2025, 12:41 PM
Unknown Object (File)
Apr 9 2025, 7:50 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP753828649956: Fix missing link targets for "View Object" header buttons in HTML email
Summary

See https://discourse.phabricator-community.org/t/view-task-from-maniphest-e-mail-doesnt-have-url/2827.

I added "View Task" / "View Commit" buttons recently but the logic for generating URIs isn't quite right. Fix it up.

Test Plan
  • Commented on a task.
  • Used bin/mail show-outbound --id ... --dump-html > out.html to dump the HTML.
  • Previewed the HTML in a browser.
  • This time, actually clicked the button to go to the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
3 lines
differential/
editor/
6 lines
maniphest/
editor/
3 lines
transactions/
editor/
32 lines

Diff 49112

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility