Page MenuHomePhabricator

Fix missing link targets for "View Object" header buttons in HTML email
ClosedPublic

Authored by epriestley on Tue, Jun 18, 2:25 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/view-task-from-maniphest-e-mail-doesnt-have-url/2827.

I added "View Task" / "View Commit" buttons recently but the logic for generating URIs isn't quite right. Fix it up.

Test Plan
  • Commented on a task.
  • Used bin/mail show-outbound --id ... --dump-html > out.html to dump the HTML.
  • Previewed the HTML in a browser.
  • This time, actually clicked the button to go to the task.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Jun 18, 2:25 PM
epriestley requested review of this revision.Tue, Jun 18, 2:27 PM
amckinley accepted this revision.Tue, Jun 18, 8:15 PM
This revision is now accepted and ready to land.Tue, Jun 18, 8:15 PM