Page MenuHomePhabricator

Fix missing link targets for "View Object" header buttons in HTML email
ClosedPublic

Authored by epriestley on Jun 18 2019, 2:25 PM.
Tags
None
Referenced Files
F19057255: D20586.id.diff
Nov 28 2025, 9:42 PM
F19050487: D20586.diff
Nov 27 2025, 8:06 PM
F18964108: D20586.diff
Nov 14 2025, 5:00 AM
F18867095: D20586.id49112.diff
Nov 3 2025, 9:29 PM
F18836101: D20586.id.diff
Oct 26 2025, 10:03 PM
F18741411: D20586.id49104.diff
Oct 2 2025, 12:42 PM
F18570512: D20586.id49112.diff
Sep 10 2025, 3:26 AM
F18570509: D20586.id49104.diff
Sep 10 2025, 3:26 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/view-task-from-maniphest-e-mail-doesnt-have-url/2827.

I added "View Task" / "View Commit" buttons recently but the logic for generating URIs isn't quite right. Fix it up.

Test Plan
  • Commented on a task.
  • Used bin/mail show-outbound --id ... --dump-html > out.html to dump the HTML.
  • Previewed the HTML in a browser.
  • This time, actually clicked the button to go to the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable