Page MenuHomePhabricator

"Sign With MFA" requires "CAN_EDIT" permission, but should only require "CAN_INTERACT" permission
Closed, ResolvedPublic

Description

See PHI1291. To reproduce:

  • View a task you have permission to see, but do not have permission to edit.
  • Add a comment and try to sign your comment with MFA.

Expected behavior:

  • You can explicitly "Sign with MFA" even if you can't edit.

Actual behavior:

  • You can not "Sign with MFA" unless you can edit.

The "Sign with MFA" action is an interaction (like a comment), not an edit, so it shouldn't require edit permission.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley triaged this task as Normal priority.Jun 6 2019, 2:18 AM
epriestley created this task.
epriestley added a revision: Restricted Differential Revision.Jun 6 2019, 2:23 AM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jun 17 2019, 5:41 PM
epriestley added a commit: Restricted Diffusion Commit.