Page MenuHomePhabricator

Audit code does not fully respect committer identities as commit authors
Closed, ResolvedPublic

Description

See PHI1303. In this issue, a user is the author of a commit only via repository identity. Audit is confused about this and is treating the commit as though it has no author.

This is probably a getAuthorPHID() somewhere that should be a getCommitIdentityAuthorPHID().

Likely reproduction steps are:

  • Commit and push as quack <xyz@abc.example> (a made-up identity string with no corresponding user).
  • Manually set the user associated with this identity to alice (or whatever).
  • View the commit as alice.

Expected behavior:

  • Alice has audit actions as the commit author.

Anticipated behavior:

  • Alice has auditor actions as though she were a non-author.