Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 2 2025, 5:55 AM
Unknown Object (File)
Apr 30 2025, 12:05 AM
Unknown Object (File)
Apr 18 2025, 7:51 PM
Unknown Object (File)
Apr 13 2025, 7:49 PM
Unknown Object (File)
Apr 10 2025, 1:08 PM
Unknown Object (File)
Apr 8 2025, 12:53 AM
Unknown Object (File)
Apr 5 2025, 9:44 PM
Unknown Object (File)
Apr 4 2025, 2:43 PM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable