Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
F18842734: D20580.diff
Tue, Oct 28, 6:05 PM
F18830012: D20580.diff
Sat, Oct 25, 3:13 AM
F18821640: D20580.id.diff
Thu, Oct 23, 1:00 AM
F18791494: D20580.id49099.diff
Thu, Oct 16, 2:05 PM
F18772255: D20580.id49085.diff
Thu, Oct 9, 1:24 AM
F18570453: D20580.id49099.diff
Sep 10 2025, 3:25 AM
F18570445: D20580.id49085.diff
Sep 10 2025, 3:25 AM
F18567016: D20580.id.diff
Sep 9 2025, 3:27 PM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable