Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
F18772255: D20580.id49085.diff
Thu, Oct 9, 1:24 AM
F18570453: D20580.id49099.diff
Sep 10 2025, 3:25 AM
F18570445: D20580.id49085.diff
Sep 10 2025, 3:25 AM
F18567016: D20580.id.diff
Sep 9 2025, 3:27 PM
F18362450: D20580.diff
Aug 27 2025, 1:56 PM
F18103502: D20580.id49099.diff
Aug 10 2025, 5:59 AM
F18098902: D20580.id.diff
Aug 8 2025, 11:45 PM
F18092058: D20580.diff
Aug 7 2025, 4:19 AM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable