Page MenuHomePhabricator

In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes

Authored by epriestley on Jun 17 2019, 4:51 PM.
Referenced Files
Unknown Object (File)
Wed, Dec 6, 9:50 PM
Unknown Object (File)
Thu, Nov 30, 6:06 AM
Unknown Object (File)
Sat, Nov 25, 10:03 PM
Unknown Object (File)
Sun, Nov 19, 5:25 AM
Unknown Object (File)
Oct 31 2023, 2:57 PM
Unknown Object (File)
Oct 19 2023, 8:29 AM
Unknown Object (File)
Sep 26 2023, 4:43 AM
Unknown Object (File)
Sep 26 2023, 4:43 AM



Fixes T13313. The "Download Raw Diff" workflow in Differential currently uses an older way of interacting with Files that doesn't engage the chunk engine and can't handle 8MB+ files.

Update to IteratorFileUploadSource -- we're still passing in a single giant blob, but this approach can be chunked.

This will still break somewhere north of 8MB (it will break at 2GB with the PHP string limit if nowhere sooner, since we're putting the entire raw diff in $raw_diff rather than using a rope/stream) but will likely survive diffs in the hundreds-of-megabytes range for now.

Test Plan
  • Added str_repeat('x', 1024 * 1024 * 9) to the $raw_diff to create a 9MB+ diff.
  • Configured file storage with no engine explicitly configured for >8MB chunks (i.e., "reasonably").
  • Clicked "Download Raw Diff".
  • Before: misleading file storage engine error ("no engine can store this file").
  • After: large, raw diff response.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable