Page MenuHomePhabricator

In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
ClosedPublic

Authored by epriestley on Jun 17 2019, 4:51 PM.

Details

Summary

Fixes T13313. The "Download Raw Diff" workflow in Differential currently uses an older way of interacting with Files that doesn't engage the chunk engine and can't handle 8MB+ files.

Update to IteratorFileUploadSource -- we're still passing in a single giant blob, but this approach can be chunked.

This will still break somewhere north of 8MB (it will break at 2GB with the PHP string limit if nowhere sooner, since we're putting the entire raw diff in $raw_diff rather than using a rope/stream) but will likely survive diffs in the hundreds-of-megabytes range for now.

Test Plan
  • Added str_repeat('x', 1024 * 1024 * 9) to the $raw_diff to create a 9MB+ diff.
  • Configured file storage with no engine explicitly configured for >8MB chunks (i.e., "reasonably").
  • Clicked "Download Raw Diff".
  • Before: misleading file storage engine error ("no engine can store this file").
  • After: large, raw diff response.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 17 2019, 4:51 PM
epriestley requested review of this revision.Jun 17 2019, 4:52 PM
amckinley accepted this revision.Jun 17 2019, 7:41 PM
This revision is now accepted and ready to land.Jun 17 2019, 7:41 PM