Thanks for the review - I dropped in a comment referencing the task when committing so it's clear why this is here when the refactoring comes along 🙂
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 23 2019
May 23 2019
epriestley moved T6276: Cannot Create Named Link to URI with Brackets from Parser to Next on the Remarkup board.
epriestley moved T12191: Remarkup autocomplete can remain open after keyboard form submission from Backlog to Next on the Remarkup board.
epriestley removed a project from T10667: Improve ambiguity when resolving commits that appear in multiple repositories: Remarkup.
epriestley moved T7967: impossible to link string that contain ']' with remarkup syntax. from Backlog to Next on the Remarkup board.
epriestley edited projects for T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster, added: Phacility; removed Customer Impact, Remarkup, Feature Request.
epriestley moved T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained from Backlog to Next on the Remarkup board.
epriestley moved T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion from Backlog to Next on the Remarkup board.
epriestley edited projects for T9825: Remarkup is rendered literally in Diviner, added: Diviner; removed Remarkup.
asherkin committed rARC7329bc7c32b9: Fix arc land on odd/modern git-svn checkouts (authored by asherkin).
Fix arc land on odd/modern git-svn checkouts
asherkin closed T13293: `arc land` using git-svn fails in certain configurations as Resolved by committing rARC7329bc7c32b9: Fix arc land on odd/modern git-svn checkouts.
May 22 2019
May 22 2019
epriestley committed rP2e2dc47f0763: In the Herald test console, don't consider transactions that Herald rules… (authored by epriestley).
In the Herald test console, don't consider transactions that Herald rules…
epriestley committed rP31e623afcc92: Use the same transaction group ID for transactions applied indirectly by a sub… (authored by epriestley).
Use the same transaction group ID for transactions applied indirectly by a sub…
epriestley committed rPf6af1c437424: When creating a Phriction document, mark initial transactions as "create"… (authored by epriestley).
When creating a Phriction document, mark initial transactions as "create"…
epriestley committed rPb95bf722d55e: Drop the "update revision with commit diff" transaction if the revision is… (authored by epriestley).
Drop the "update revision with commit diff" transaction if the revision is…
epriestley committed rP1eff4fdca332: Prevent "Differential Revision: ..." from counting as a mention in commit… (authored by epriestley).
Prevent "Differential Revision: ..." from counting as a mention in commit…
epriestley committed rPfa4dcaa3aaff: Stabilize sorting of feed stories with similar strength (authored by epriestley).
Stabilize sorting of feed stories with similar strength
epriestley added a comment to D20546: Use the same transaction group ID for transactions applied indirectly by a sub-editor.
D20547 alone would also fix this specific problem (by skipping the Herald transactions), but I think this change is good on its own and generally makes behavior more consistent/expected.
Reading PHI1222; nice catch!
epriestley added a comment to T13283: When Herald acts, include the transaction group as part of the "state" it acts upon.
Currently, I think the primary transactions and transactions triggered by Herald are getting different group IDs. They should be the same group ID, e.g. all these transactions should be in the same "group" for the purposes of collecting transactions into effect groups:
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".
(This is mostly for my own notes and contains roughly zero insight.)
If we were just doing personal notification sounds, I think there'd be a good argument for making this a Settings panel.
epriestley triaged T13293: `arc land` using git-svn fails in certain configurations as Low priority.
epriestley added projects to T13293: `arc land` using git-svn fails in certain configurations: Arcanist, Git, Subversion.
Thanks, T13293 makes this much clearer.
Per D20533, the major query this UI uses is currently unkeyed (no dateCreated key on transaction tables).
epriestley committed rPf91bef64f163: Stack chart functions in a more physical way (authored by epriestley).
Stack chart functions in a more physical way
epriestley committed rPf190c42bcd2e: Store charts earlier and build them out a little later (authored by epriestley).
Store charts earlier and build them out a little later
epriestley committed rP493a6b72c1c0: Automatically select the range for charts in a general way (authored by epriestley).
Automatically select the range for charts in a general way
epriestley committed rPe90360c28967: Wrap "<min, max>" chart domain pairs in an "Interval" class (authored by epriestley).
Wrap "<min, max>" chart domain pairs in an "Interval" class
epriestley committed rPa80426b339c4: Provide chart function labels over the wire instead of making them up (authored by epriestley).
Provide chart function labels over the wire instead of making them up
epriestley added inline comments to D20501: Provide chart function labels over the wire instead of making them up.
Label important data on charts
Roughly support stacked area charts
Update D3 to the current version
epriestley committed rP5c1b91ab457d: Consolidate burndown logic into a "BurndownChartEngine" (authored by epriestley).
Consolidate burndown logic into a "BurndownChartEngine"
epriestley committed rP0aee3da19e6a: Add a "Reports" menu item to Projects (authored by epriestley).
Add a "Reports" menu item to Projects
epriestley committed rPf87c1ac362a7: Start the fact daemon in "bin/phd start" (authored by epriestley).
Start the fact daemon in "bin/phd start"
epriestley committed rP10afe1f2b59c: Fix handling of "null" domain values in Charts (authored by epriestley).
Fix handling of "null" domain values in Charts
epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
epriestley committed rP146317f2c447: Remove the legacy chart behavior from Maniphest (authored by epriestley).
Remove the legacy chart behavior from Maniphest
epriestley committed rPf8ebc71b8f21: Replace the chart in Maniphest Reports with a chart driven by Facts (authored by epriestley).
Replace the chart in Maniphest Reports with a chart driven by Facts
Add a rough "Chart" Dashboard Panel
epriestley committed rPc458b50b8569: Render charts from storage instead of just one ad-hoc hard-coded chart (authored by epriestley).
Render charts from storage instead of just one ad-hoc hard-coded chart
(We also don't need to tick the y-max -- we could tick at 100 and draw to 110.)
Yeah, I ideally want to try to round up, up to X%, to the nearest "nice" number, like if the range is 0-93 we show 0-100, since "100" is the nearest "nice round number" above 93. There was some simple code for this before (visual-max = actual-max * 1.2 or something) which makes the shape of the graph look good but doesn't produce the most satisfying ticks on the Y-axis or the ideally satisfying Y-max.
Implement parseVersionOutput in ArcanistExternalLinter so that it can be called from within another instance of ArcanistExternalLinter
Rebase
Rebase
Unrelated but I noticed that ArcanistBundleTestCase::testGitRepository fails locally for me when running arc unit --everything:
May 21 2019
May 21 2019