HomePhabricator

Consolidate burndown logic into a "BurndownChartEngine"

Authored by epriestley on May 3 2019, 7:14 PM.

Description

Consolidate burndown logic into a "BurndownChartEngine"

Summary:
Ref T13279. For now, we need to render burndowns from both Maniphest (legacy) and Projects (new prototype).

Consolidate this logic into a "BurndownChartEngine". I plan to expand this to work a bit like a "SearchEngine", and serve as a UI layer on top of the raw chart features.

The old "ChartEngine" is now "ChartRenderingEngine".

Test Plan:

  • Viewed burndowns ("burnups") in Maniphest.
  • Viewed burndowns in Projects.
  • Saw the same chart.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Maniphest Tasks: T13279

Differential Revision: https://secure.phabricator.com/D20496

Details

Committed
epriestleyMay 22 2019, 12:10 PM
Pushed
epriestleyMay 22 2019, 12:10 PM
Reviewer
amckinley
Differential Revision
D20496: Consolidate burndown logic into a "BurndownChartEngine"
Parents
rP0aee3da19e6a: Add a "Reports" menu item to Projects
Branches
Unknown
Tags
Unknown
Tasks
T13279: Build Charting for Facts
Build Status
Buildable 22873
Build 31379: Run Core Tests