HomePhabricator

Roughly support stacked area charts

Authored by epriestley on May 3 2019, 7:26 PM.

Description

Roughly support stacked area charts

Summary:
Ref T13279. This adds support for:

  • Datasets can have types, like "stacked area".
  • Datasets can have multiple functions.
  • Charts can store dataset types and datasets with multiple functions.
  • Adds a "stacked area" dataset.
  • Makes D3 actually draw a stacked area chart.

Lots of rough edges here still, but the result looks slightly more like it's supposed to look.

D3 can do some of this logic itself, like adding up the area stacks on top of one another with d3.stack(). I'm doing it in PHP instead because I think it's a bit easier to debug, and it gives us more options for things like caching or "export to CSV" or "export to API" or rendering a data table under the chart or whatever.

Test Plan:

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim

Maniphest Tasks: T13279

Differential Revision: https://secure.phabricator.com/D20498

Details

Committed
epriestleyMay 22 2019, 12:19 PM
Pushed
epriestleyMay 22 2019, 12:19 PM
Reviewer
amckinley
Differential Revision
D20498: Roughly support stacked area charts
Parents
rP0776b5ca2c4d: Update D3 to the current version
Branches
Unknown
Tags
Unknown
Tasks
T13279: Build Charting for Facts
Build Status
Buildable 22875
Build 31381: Run Core Tests