Page MenuHomePhabricator

Label important data on charts
ClosedPublic

Authored by epriestley on May 8 2019, 1:55 PM.
Tags
None
Referenced Files
F22512317: D20500.diff
Sat, Sep 19, 4:15 AM
Unknown Object (File)
Jun 18 2026, 12:01 AM
Unknown Object (File)
Jun 2 2026, 6:39 AM
Unknown Object (File)
Mar 31 2026, 9:57 PM
Unknown Object (File)
Mar 5 2026, 4:11 AM
Unknown Object (File)
Feb 10 2026, 6:57 PM
Unknown Object (File)
Feb 4 2026, 12:11 AM
Unknown Object (File)
Jan 21 2026, 8:53 AM
Subscribers

Details

Summary

Ref T13279. Adds client-side support for rendering function labels on charts, then labels every function as important data.

Works okay on mobile, although I'm not planning to target mobile terribly heavily for v0.

Test Plan

Screen Shot 2019-05-08 at 6.50.04 AM.png (1×1 px, 233 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I'm leaning toward putting a fair amount of this rendering in JS since I anticipate a lot of JS nonsense later on (hover/click lines, areas, data points, function labels, etc) and all the SVG rendering is somewhat-necessarily in JS anyway.

This revision is now accepted and ready to land.May 21 2019, 9:36 PM