Page MenuHomePhabricator

Label important data on charts
ClosedPublic

Authored by epriestley on May 8 2019, 1:55 PM.

Details

Summary

Ref T13279. Adds client-side support for rendering function labels on charts, then labels every function as important data.

Works okay on mobile, although I'm not planning to target mobile terribly heavily for v0.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 8 2019, 1:55 PM

I'm leaning toward putting a fair amount of this rendering in JS since I anticipate a lot of JS nonsense later on (hover/click lines, areas, data points, function labels, etc) and all the SVG rendering is somewhat-necessarily in JS anyway.

epriestley requested review of this revision.May 8 2019, 1:57 PM
amckinley accepted this revision.May 21 2019, 9:36 PM
This revision is now accepted and ready to land.May 21 2019, 9:36 PM
This revision was automatically updated to reflect the committed changes.