Page MenuHomePhabricator

Commit list changes based on hash in URL
Open, Needs TriagePublic

Description

The list of commits included in a merge commit will (erroneously?) include itself unless the URL used to view the commit includes the full commit hash

This is reproducible with both mercurial and git, and can be seen on the secure.phabricator.com site:

Compare the list of commits here:
https://secure.phabricator.com/rHGTEST8dee87000fef682e92792d795b6e8aea634f5085
vs.
https://secure.phabricator.com/rHGTEST8dee87000fef682e92792d795b6e8aea634f508

And on git:
https://secure.phabricator.com/rGITTESTb36f98224cf15f14afea24e2f9d1fa80e56a1d25
vs.
https://secure.phabricator.com/rGITTESTb36f98224cf15f14afea24e2f9d1fa80e56a1d2

This can come across in real life as Remarkup picks up hashes and auto-links them using only the typed hash. I think this is frequently 12 characters of hash for merurial, probably also git.