Page MenuHomePhabricator

Use the same transaction group ID for transactions applied indirectly by a sub-editor
ClosedPublic

Authored by epriestley on May 22 2019, 9:41 PM.

Details

Summary

Ref T13283. Currently, each Editor sets its own group ID, so if you create a revision and then Herald does some stuff, the two groups of transactions get different group IDs.

This means the test console is slightly misleading (it will only pick up the Herald transactions). It's going to be misleading anyway (Herald obviously can't evaluate Herald transactions) but this is at least a little closer to reality and stops Herald actions from masking non-Herald actions.

Test Plan
  • Created a revision. Herald applied one transaction.
  • Used the test console.
  • Before: The test console only picked up the single most recent Herald transaction.
  • After: The test console picked up the whole transaction group.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 22 2019, 9:41 PM
epriestley requested review of this revision.May 22 2019, 9:43 PM

D20547 alone would also fix this specific problem (by skipping the Herald transactions), but I think this change is good on its own and generally makes behavior more consistent/expected.

amckinley accepted this revision.May 22 2019, 10:30 PM
This revision is now accepted and ready to land.May 22 2019, 10:30 PM