Page MenuHomePhabricator

When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email
ClosedPublic

Authored by epriestley on May 22 2019, 10:15 PM.
Tags
None
Referenced Files
F17936711: D20548.id49019.diff
Thu, Jul 31, 12:31 AM
F17758140: D20548.id49011.diff
Tue, Jul 22, 4:53 PM
F17757911: D20548.id.diff
Tue, Jul 22, 4:34 PM
F17737577: D20548.diff
Sun, Jul 20, 9:07 PM
F17665861: D20548.diff
Sat, Jul 12, 8:30 PM
Unknown Object (File)
Jul 2 2025, 9:49 PM
Unknown Object (File)
Jul 2 2025, 3:17 PM
Unknown Object (File)
Jul 2 2025, 6:13 AM
Subscribers
None

Details

Summary

Ref T13289. When you create a Phriction document, you currently get an email with the whole new content as a "diff".

You also get extra transactions in the email and on the page.

This is because Phriction isn't on EditEngine and doesn't mark "create" transactions in a modern way. Get them marked properly to fix these obviously-broken behaviors. This can all go away once Phriction switches to EditEngine, although I don't have any particular plans to do that in the immediate future.

Test Plan
  • Created a new document, viewed email, no longer saw redundant "edited content" transaction or "CHANGES TO CONTENT" diff.
  • Updated a document, viewed email, got interdiff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable