Page MenuHomePhabricator

When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email
ClosedPublic

Authored by epriestley on May 22 2019, 10:15 PM.
Tags
None
Referenced Files
F18329839: D20548.id49019.diff
Mon, Aug 25, 12:40 AM
F18287074: D20548.id.diff
Sat, Aug 23, 7:04 AM
F18102629: D20548.id49011.diff
Sat, Aug 9, 10:15 PM
F18101527: D20548.id.diff
Sat, Aug 9, 2:10 PM
F18100538: D20548.id.diff
Sat, Aug 9, 11:56 AM
F18099597: D20548.id49019.diff
Sat, Aug 9, 6:40 AM
F18095371: D20548.diff
Thu, Aug 7, 11:18 PM
F18088244: D20548.id49011.diff
Wed, Aug 6, 7:22 AM
Subscribers
None

Details

Summary

Ref T13289. When you create a Phriction document, you currently get an email with the whole new content as a "diff".

You also get extra transactions in the email and on the page.

This is because Phriction isn't on EditEngine and doesn't mark "create" transactions in a modern way. Get them marked properly to fix these obviously-broken behaviors. This can all go away once Phriction switches to EditEngine, although I don't have any particular plans to do that in the immediate future.

Test Plan
  • Created a new document, viewed email, no longer saw redundant "edited content" transaction or "CHANGES TO CONTENT" diff.
  • Updated a document, viewed email, got interdiff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable