Page MenuHomePhabricator

When creating a Phriction document, mark initial transactions as "create" transactions to fix weird email
ClosedPublic

Authored by epriestley on May 22 2019, 10:15 PM.
Tags
None
Referenced Files
F14081224: D20548.diff
Fri, Nov 22, 6:49 PM
Unknown Object (File)
Thu, Nov 14, 2:11 PM
Unknown Object (File)
Sun, Nov 10, 8:10 AM
Unknown Object (File)
Fri, Oct 25, 7:25 PM
Unknown Object (File)
Oct 18 2024, 9:04 AM
Unknown Object (File)
Oct 11 2024, 12:39 PM
Unknown Object (File)
Oct 11 2024, 11:48 AM
Unknown Object (File)
Oct 11 2024, 11:47 AM
Subscribers
None

Details

Summary

Ref T13289. When you create a Phriction document, you currently get an email with the whole new content as a "diff".

You also get extra transactions in the email and on the page.

This is because Phriction isn't on EditEngine and doesn't mark "create" transactions in a modern way. Get them marked properly to fix these obviously-broken behaviors. This can all go away once Phriction switches to EditEngine, although I don't have any particular plans to do that in the immediate future.

Test Plan
  • Created a new document, viewed email, no longer saw redundant "edited content" transaction or "CHANGES TO CONTENT" diff.
  • Updated a document, viewed email, got interdiff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable