Page MenuHomePhabricator

Provide chart function labels over the wire instead of making them up
ClosedPublic

Authored by epriestley on Wed, May 8, 2:22 PM.

Details

Summary

Ref T13279. Makes charts incrementally more useful by allowing the server to provide labels and colors for functions.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, May 8, 2:22 PM
epriestley requested review of this revision.Wed, May 8, 2:24 PM
amckinley accepted this revision.Tue, May 21, 9:38 PM
amckinley added inline comments.
src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php
138

Intended placeholder?

This revision is now accepted and ready to land.Tue, May 21, 9:38 PM
epriestley added inline comments.Wed, May 22, 12:22 PM
src/applications/fact/chart/PhabricatorChartStackedAreaDataset.php
138

Yeah, I think this gets a real name in a followup.