Page MenuHomePhabricator
Feed All Stories

May 10 2019

joshuaspence edited the content of Community Resources.
May 10 2019, 12:52 AM

May 9 2019

epriestley abandoned D12692: Allow full URIs to be rendered as object references.

D20511 + D20512 appear to give us a way forward here.

May 9 2019, 8:41 PM
epriestley requested review of D20512: Specialize rendering of self-URIs in the form "/X123".

(Test failures are because of D20511 not being landed yet.)

May 9 2019, 8:40 PM
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20512: Specialize rendering of self-URIs in the form "/X123".
May 9 2019, 8:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Got it, thanks for clarifying.

May 9 2019, 8:05 PM · Workboards (v3), Restricted Project
epriestley requested review of D20511: Provide an extension point for handling hyperlinks in remarkup in a special way.
May 9 2019, 7:59 PM
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20511: Provide an extension point for handling hyperlinks in remarkup in a special way.
May 9 2019, 7:59 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop). Is this expected / intentional?

May 9 2019, 6:54 PM · Workboards (v3), Restricted Project
igoldberg added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

It looks like these triggers don't run when you move tasks via "Move on Workboard" (instead of drag and drop).

May 9 2019, 6:51 PM · Workboards (v3), Restricted Project
epriestley added a subtask for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T9720: Provide a way to link to Diffusion files.
May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley added a parent task for T9720: Provide a way to link to Diffusion files: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:31 PM · Restricted Project, Remarkup
epriestley added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

PHI1224 describes a somewhat-adjacent situation: an install would like a way for external automated tooling to reference source files and generate editor links for them.

May 9 2019, 6:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley requested review of D20510: When a user pastes a Phabricator URI into the search box, redirect to the URI.
May 9 2019, 6:24 PM
epriestley claimed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley removed a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T7443: Include full link to Maniphest tasks in commit messages.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley removed a subtask for T7443: Include full link to Maniphest tasks in commit messages: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Diffusion, Arcanist
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20510: When a user pastes a Phabricator URI into the search box, redirect to the URI.
May 9 2019, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.
May 9 2019, 6:21 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley updated the summary of D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.
May 9 2019, 6:21 PM
epriestley requested review of D20509: Remove ancient "PhabricatorQuickSearchEngineExtension" compatibility class.
May 9 2019, 6:15 PM
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1231 would like API access to coverage.

May 9 2019, 5:51 PM · Diffusion, Plans
epriestley moved T11372: Multiple coverage columns for different types of code coverage from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley edited projects for T11372: Multiple coverage columns for different types of code coverage, added: Diffusion; removed Feature Request.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley closed T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository as Resolved.

My expectation is that this is effectively resolved by T13277. Since "Autoclose" is no longer a separate permission from "Publish", commits should now always mention + close or never mention + close.

May 9 2019, 5:05 PM · Transactions, Diffusion
epriestley moved T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published from Backlog to "Track Only" on the Diffusion board.
May 9 2019, 5:03 PM · Diffusion
epriestley moved T9524: Show aggregate subdirectory coverage in Diffusion browse views from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Restricted Project
epriestley moved T13125: Plans: Code coverage reporting from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Plans
epriestley requested review of D20508: Expose subscribers transaction data via Conduit "transaction.search".
May 9 2019, 4:22 PM
epriestley requested review of D20507: Enrich "draft", "summary", and "testPlan" transactions from Differential in "transaction.search".
May 9 2019, 4:10 PM

May 8 2019

epriestley added inline comments to D20506: Stack chart functions in a more physical way.
May 8 2019, 7:56 PM
epriestley requested review of D20506: Stack chart functions in a more physical way.
May 8 2019, 7:56 PM
epriestley added a revision to T13279: Build Charting for Facts: D20506: Stack chart functions in a more physical way.
May 8 2019, 7:54 PM · Plans, Facts
leoluk added a comment to D20493: Make branch status more clear on Diffusion branches view.

Typo in commit message

May 8 2019, 7:25 PM
epriestley added a comment to T13279: Build Charting for Facts.

The actual facts Maniphest currently generates need to be adjusted to properly support stacked-area-by-reason: currently, when a task is closed, we don't have enough data to figure out whether it should be removed from the "created into this project" area, the "reopened work" area, or the "moved work" area.

May 8 2019, 7:14 PM · Plans, Facts
epriestley requested review of D20505: Remove unnecessary "," from Pylint version regex.
May 8 2019, 5:22 PM
epriestley added a comment to D20504: Store charts earlier and build them out a little later.

Roughly, old flow was:

May 8 2019, 4:40 PM
epriestley requested review of D20504: Store charts earlier and build them out a little later.
May 8 2019, 4:36 PM
epriestley added a revision to T13279: Build Charting for Facts: D20504: Store charts earlier and build them out a little later.
May 8 2019, 4:35 PM · Plans, Facts
epriestley requested review of D20503: Automatically select the range for charts in a general way.
May 8 2019, 3:57 PM
epriestley added a revision to T13279: Build Charting for Facts: D20503: Automatically select the range for charts in a general way.
May 8 2019, 3:55 PM · Plans, Facts
epriestley requested review of D20502: Wrap "<min, max>" chart domain pairs in an "Interval" class.
May 8 2019, 3:46 PM
epriestley added a revision to T13279: Build Charting for Facts: D20502: Wrap "<min, max>" chart domain pairs in an "Interval" class.
May 8 2019, 3:44 PM · Plans, Facts
epriestley requested review of D20501: Provide chart function labels over the wire instead of making them up.
May 8 2019, 2:24 PM
epriestley added a revision to T13279: Build Charting for Facts: D20501: Provide chart function labels over the wire instead of making them up.
May 8 2019, 2:22 PM · Plans, Facts
epriestley requested review of D20500: Label important data on charts.
May 8 2019, 1:57 PM
epriestley added a revision to T13279: Build Charting for Facts: D20500: Label important data on charts.
May 8 2019, 1:55 PM · Plans, Facts
wppd edited the content of Organizations Using Phabricator.
May 8 2019, 10:13 AM

May 7 2019

epriestley committed rP7a8d489ebdbd: Fix a HunkParser typo, "identcal" -> "identical" (authored by epriestley).
Fix a HunkParser typo, "identcal" -> "identical"
May 7 2019, 6:17 PM
epriestley closed D20499: Fix a HunkParser typo, "identcal" -> "identical".
May 7 2019, 6:17 PM
avivey accepted D20499: Fix a HunkParser typo, "identcal" -> "identical".

This is a change I can stand behind. Looks good!

May 7 2019, 5:02 PM
Herald updated subscribers of T4752: Daemons may not have permission to remove files from local disk storage engine.
May 7 2019, 3:05 PM · Files
epriestley added a comment to T13279: Build Charting for Facts.

One issue with model we're evolving toward is that if you view a chart in Klingon, then send the link to a user whose primary language is Kerbal, we'd prefer to relabel the chart in Kerbal, not restore serialized Klingon-language chart labels. That means label generation has to be at render time, not at chart construction time, and I'm serializing a data-structure which is slightly too low-level for common application cases.

May 7 2019, 2:07 PM · Plans, Facts
epriestley requested review of D20499: Fix a HunkParser typo, "identcal" -> "identical".
May 7 2019, 1:31 PM
Krinkle awarded rP3f8eccdaec8f: Put some whitespace behaviors back, but only for "diff alignment", not display a Orange Medal token.
May 7 2019, 11:55 AM

May 5 2019

epriestley added a comment to T13279: Build Charting for Facts.

This is a little ways out, but the actual facts Maniphest currently generates need to be adjusted to properly support stacked-area-by-reason: currently, when a task is closed, we don't have enough data to figure out whether it should be removed from the "created into this project" area, the "reopened work" area, or the "moved work" area. This is okay if we're summing the opens/closes but not precise enough if we're breaking them down.

May 5 2019, 2:48 PM · Plans, Facts

May 4 2019

epriestley added a comment to T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.

Probably, push another commit to Y

May 4 2019, 5:28 PM · Diffusion

May 3 2019

epriestley requested review of D20498: Roughly support stacked area charts.
May 3 2019, 10:46 PM
epriestley added a revision to T13279: Build Charting for Facts: D20498: Roughly support stacked area charts.
May 3 2019, 10:44 PM · Plans, Facts
epriestley requested review of D20497: Update D3 to the current version.
May 3 2019, 10:17 PM
epriestley added a revision to T13279: Build Charting for Facts: D20497: Update D3 to the current version.
May 3 2019, 10:15 PM · Plans, Facts
epriestley requested review of D20496: Consolidate burndown logic into a "BurndownChartEngine".
May 3 2019, 7:18 PM
epriestley added a revision to T13279: Build Charting for Facts: D20496: Consolidate burndown logic into a "BurndownChartEngine".
May 3 2019, 7:16 PM · Plans, Facts
epriestley requested review of D20495: Add a "Reports" menu item to Projects.
May 3 2019, 6:55 PM
epriestley added a revision to T13279: Build Charting for Facts: D20495: Add a "Reports" menu item to Projects.
May 3 2019, 6:54 PM · Plans, Facts
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 3 2019, 5:37 PM · Diffusion
epriestley triaged T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published as Low priority.
May 3 2019, 5:35 PM · Diffusion
epriestley requested review of D20494: Fix a potential double-prompt in "arc land" when landing with ongoing builds.
May 3 2019, 5:17 PM
epriestley requested review of D20493: Make branch status more clear on Diffusion branches view.
May 3 2019, 5:13 PM
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": D20493: Make branch status more clear on Diffusion branches view.
May 3 2019, 5:11 PM · Plans, Diffusion
kylec awarded D20492: Add support for custom "Wait for Approval" instructions a Love token.
May 3 2019, 5:08 PM
epriestley added a comment to D20492: Add support for custom "Wait for Approval" instructions.

And, obviously, fixing the flow to just work would be ideal, but that's like a thousand miles away through the swamps of T5953, and maybe not even then in this case (where part of the issue was using provider X as an authority, and provider Y as an actual login provider).

May 3 2019, 3:33 PM
epriestley requested review of D20492: Add support for custom "Wait for Approval" instructions.
May 3 2019, 3:31 PM
epriestley requested review of D20491: Hide the "added a commit/revision" stories from feed and mail.
May 3 2019, 3:01 PM
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: D20491: Hide the "added a commit/revision" stories from feed and mail.
May 3 2019, 3:00 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13279: Build Charting for Facts.

Multiple Project Burnups Stacked in an Area Chart

May 3 2019, 2:56 PM · Plans, Facts
epriestley added a comment to T13279: Build Charting for Facts.

See also PHI1226. An install has an environment where automatic rules (Herald/Owners) frequently trigger group reviewers (projects/packages), and some groups are not prompt about performing review.

May 3 2019, 2:35 PM · Plans, Facts
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to Next on the Herald board.
May 3 2019, 5:11 AM · Diffusion, Harbormaster, Herald, Audit
epriestley triaged T13283: When Herald acts, include the transaction group as part of the "state" it acts upon as Normal priority.
May 3 2019, 5:11 AM · Herald
epriestley added a comment to T6491: Herald rules based on age.

See PHI1107, which requests Auto-Abandon for old changes and also has a technical outline for this great and wholesome feature.

May 3 2019, 5:04 AM · Restricted Project, Herald
joshuaspence edited the content of Community Resources.
May 3 2019, 4:59 AM
joshuaspence edited the content of Community Resources.
May 3 2019, 4:58 AM
epriestley closed T5462: How do I publish Phabricator events into remote systems? as Resolved.

The answer here is now pretty unambiguously "Use Webhooks". feed.http-hooks is formally deprecated, Herald remains a terrible idea, and anyone brave enough to touch Doorkeeper can probably figure things out for themselves.

May 3 2019, 4:57 AM · Guides, Herald, Feed, Doorkeeper
epriestley closed T5547: Allow members of a project to add rules with project reviewers as Wontfix.

We don't have any current customer interest in this as far as I'm aware. We could revisit this in the future, but I'd like better / more modern use cases (e.g., that aren't addressed by an approach with Owners).

May 3 2019, 4:56 AM · Restricted Project, Herald
epriestley moved T6491: Herald rules based on age from Backlog to Next on the Herald board.
May 3 2019, 4:53 AM · Restricted Project, Herald
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T6183: Allow any user to watch projects, as Resolved.
May 3 2019, 4:53 AM · Wikimedia, Projects
epriestley closed T7703: Policy checks may execute incompletely for non-viewers as Resolved.

Although I'm not entirely confident that 100% of objects which should implement ExtendedPolicyInterface actually do today, I think we've gotten pretty much all of them. This approach also seems stable.

May 3 2019, 4:53 AM · Policy, Herald, Flags
epriestley closed T7703: Policy checks may execute incompletely for non-viewers, a subtask of T8377: Build the core "Spaces" Application, as Resolved.
May 3 2019, 4:53 AM · Spaces, Wikimedia, Policy
epriestley moved T9136: '(Disabled)' rules show up multi times under 'Another Herald Rule' from Backlog to Next on the Herald board.
May 3 2019, 4:44 AM · Restricted Project, Herald
epriestley closed T9766: Expose conduit API to activate/disable Herald rules as Wontfix.

I don't believe there are remaining outstanding requests for this.

May 3 2019, 4:44 AM · Restricted Project, Restricted Project, Conduit, Herald
epriestley moved T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Backlog to Far Future on the Herald board.
May 3 2019, 4:40 AM · Diffusion, Herald
epriestley closed T11118: Herald Rule to assign Owners to an Audit as Wontfix.

Owners review and auditing now have 6 and 4 options respectively, which I think cover most of the needs here. They don't handle everything (e.g. excluding merge commits) but think we're mostly in a reasonable place now and don't have any current plans to add additional shorthands.

May 3 2019, 4:39 AM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley renamed T406: Support "Oncall" Users from Build Oncall / Alerting / Monitoring tool, similar to PagerDuty to Support "Oncall" Users.
May 3 2019, 4:22 AM · Nuance, Facebook, Oncall Tool

May 2 2019

epriestley committed rP5dc4e76eb9f8: Fix the direction of the commit/revision edge (authored by epriestley).
Fix the direction of the commit/revision edge
May 2 2019, 2:29 PM
epriestley closed D20490: Fix the direction of the commit/revision edge.
May 2 2019, 2:28 PM
amckinley accepted D20490: Fix the direction of the commit/revision edge.
May 2 2019, 12:50 PM

May 1 2019

epriestley committed rPaba7d1406ac8: Really fix movable panels inside tab panels by changing the JX.Request… (authored by epriestley).
Really fix movable panels inside tab panels by changing the JX.Request…
May 1 2019, 10:38 PM
epriestley closed D20476: Really fix movable panels inside tab panels by changing the JX.Request serializer.
May 1 2019, 10:38 PM
epriestley committed rPc43618a3a8bb: Add "Move Left" and "Move Right" to dashboard tab panels (authored by epriestley).
Add "Move Left" and "Move Right" to dashboard tab panels
May 1 2019, 10:36 PM
epriestley closed D20475: Add "Move Left" and "Move Right" to dashboard tab panels.
May 1 2019, 10:36 PM
epriestley committed rP9d716379a3f1: Add a "Customize Query" action to query panels to make it easier to make minor… (authored by epriestley).
Add a "Customize Query" action to query panels to make it easier to make minor…
May 1 2019, 6:01 PM