Page MenuHomePhabricator

Expose conduit API to activate/disable Herald rules
Closed, WontfixPublic

Description

The push and deployment process on my team involves temporarily activating a herald rule each day for a certain duration. Right now there's no way to do that from the commandline since no herald methods are exposed to conduit AFAICT.

I don't care about defining or modifying herald rules programmatically, but being able to activate / deactivate them for now would be a big win for us.

Event Timeline

chad added a project: Restricted Project.Nov 11 2015, 6:31 PM

Just to clarify, you would rather rely on an external script to activate and deactivate this rule every day instead of having a Herald condition like "Current time is between 5PM and 9AM"?

@epriestley correct.. basically we have an external system (a Jenkins-like CI tool) that we're effectively using as a workflow engine. The timing isn't strictly defined, it's basically "when the user presses the button, do all these things".

A somewhat generic way to do this is to create the notion of a variable such as is_in_deployment and allow Herald rules to check to see if this is set/true/a specific value. If the API to expose the variable is exposed to conduit then also allows for far more interesting workflows (especially when combined with relying on other Herald rules).

joshuaspence renamed this task from Expose conduit API to activate/disable herald rules? to Expose conduit API to activate/disable Herald rules.Nov 12 2015, 7:40 AM

A somewhat generic way to do this is to create the notion of a variable such as is_in_deployment and allow Herald rules to check to see if this is set/true/a specific value. If the API to expose the variable is exposed to conduit then also allows for far more interesting workflows (especially when combined with relying on other Herald rules).

That sounds like Phlux.

eadler added a project: Restricted Project.Jan 8 2016, 10:14 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jan 8 2016, 10:18 PM
eadler edited projects, added Owners; removed Restricted Project.Feb 26 2016, 7:58 PM
eadler edited projects, added Restricted Project; removed Owners.
eadler edited projects, added Restricted Project; removed Restricted Project.Jun 6 2016, 5:35 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:19 PM
epriestley claimed this task.

I don't believe there are remaining outstanding requests for this.

(A custom Herald condition could plausibly read some API-editable object like a Paste as a workaround to accomplish this.)