Page MenuHomePhabricator

'(Disabled)' rules show up multi times under 'Another Herald Rule'
Closed, ResolvedPublic

Description

Event Timeline

cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added a project: Herald.
cburroughs added a subscriber: cburroughs.

I think (?) these are different rules, none of which have names, but this UI can clearly be improved.

eadler added a project: Restricted Project.Jan 8 2016, 10:44 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:09 PM

I think the following change to src/applications/herald/controller/HeraldRuleController.php line 672 (as of 185c28f307e4) should provide an immediate improvement to at least indicate that they are different rules:

    foreach ($all_rules as $current_rule) {
      if ($current_rule->getIsDisabled()) {
        $current_rule->makeEphemeral();
-        $current_rule->setName($rule->getName().' '.pht('(Disabled)'));
+       $current_rule->setName($current_rule->getName().' '.pht('(Disabled)'));
      }
    }
epriestley moved this task from Backlog to Next on the Herald board.May 3 2019, 4:44 AM