Page MenuHomePhabricator

Herald rules based on age
Open, WishlistPublic

Description

Currently Herald does a very good job at reacting on current events. What if we could apply its power to clean the backstage as well? We are missing a way to apply Herald rules when objects or last actions come to an age.

Use cases:

  • If a task assigned to someone hasn't got any activity from its owner in N months, put it up for grabs.
  • If a task has been marked as High N months ago and there is no activity, demote it as Normal.
  • If a Needs_Info task hasn't got any activity in N months, resolve it as Declined.
  • If a Diff has been in Request Changes status for N months without a new patch uploaded, abandon it.

Event Timeline

qgil created this task.Nov 7 2014, 4:13 PM
qgil raised the priority of this task from to Needs Triage.
qgil updated the task description. (Show Details)
qgil added a project: Herald.
qgil added a project: Wikimedia.
qgil added a subscriber: qgil.

I smell a Task Reaper (cc @btrahan).

btrahan added a subscriber: jeg.Nov 8 2014, 12:11 AM

Haha, yeah, I thought of that too. In short, it was this little robot at Facebook built by @jeg that would ping tasks - "you haven't touched this in X. do something or we reap it at Y" - and then reap 'em. (@jeg - feel free to embellish...! =D )

See also T402, which I'm just going to close and point here since it's ancient.

Generally, T5207 is an accurate technical blocker. There are various time-based things we'd like to do in the future (warn you before a meeting in Calendar, bill a subscription in Phortune) that we'll need time-aware, cron-like infrastructure for. This will also potentially enable age-based Herald rules and periodic Harbormaster builds (and whatever else we come up with).

Philosophically, I'm not really convinced that nagging users is very effective or that making tasks automatically expire if left unattended for some time is a desirable behavior, but there are plenty of unambiguous uses that don't stray into this grey area (e.g., escalate high-priority issues if left untouched for an hour), and @qgil's examples are generally reasonable and less severe than the task reaper was. I'd generally want to at least structure this with those sorts of use cases in mind and only incidentally enable the nag/reaper cases, though.

T436 was another related task which rolled into T402, but roughly was a request for the ability to set reminders. I haven't seen other requests for that since then, but Calendar + time infrastructure should give us reminders for free/cheap.

btrahan triaged this task as Wishlist priority.Nov 8 2014, 7:01 AM
qgil added a comment.Nov 8 2014, 12:18 PM

I guess this request is more relevant for the open source community case than for the corporate intranet case:

  • More people might come and go for short periods of time and leave unfinished / unattended work still assigned to them.
  • Even when they leave, they might come back, so you don't want to be too harsh either.
  • Cleaning manually is boring, and frequently people take things personally so you might get in extra trouble just for cleaning.
  • However, bots don't get bored, they have time, and as long as they follow community agreed processes, nobody attempts to pick a fight with them.

Not urgent at all. Looking forward to Chronicle.

qgil moved this task from Backlog to Details on the Wikimedia board.Dec 4 2014, 12:47 PM
qgil added a comment.Jan 22 2015, 2:05 PM

Interesting update (even if [perhaps not good news for this task):

One other possible weakness is that this doesn't give us any direct tools to attack the "task reaper" use case, but I'm not really sold on the usefulness of it in the general case and I'm not sure if, e.g., Herald rules with timer conditions are the right approach anyway, since I think they're not expressive enough.
In particular, with special cases like T6821/T6491 (where the desire is to trigger, e.g., after no change in assignee status, specifically, for X days), I'm hard-pressed to imagine us ever building a system which can express those rules in a generic way. Pager escalation rules ("text everyone if no one touches this for 15 minutes") seem somewhat more practical, but just building that into a pager/monitoring tool probably makes more sense than doing it via Herald or some Chrono-Herald.
If T4434 ends up somewhat-generic-ish, the "Task Reaper" becomes easy to write as an external script, although it will have to be pretty generic to satisfy all the use cases in T6491.

fanis added a subscriber: fanis.Jun 25 2015, 11:26 AM
eadler added a project: Restricted Project.Jan 8 2016, 10:44 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
eadler removed a project: Restricted Project.Feb 24 2016, 12:07 AM
eadler added a subscriber: eadler.Mar 5 2016, 7:52 PM

Not sure if related to this task or not, but I'd love the ability to have Herald rules act on countdowns. Sometimes we have tasks that fan out to many teams and we'd like the ability to assign it to the team, but add a project or change assignee once a countdown expires.

eadler added a project: Restricted Project.Apr 11 2016, 9:41 PM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 6 2016, 4:10 PM

Another example use case: the ability to perform advanced searches based on report history criteria and to send "whines" (as on bugzilla) is needed for any project that wishes to join https://bestpractices.coreinfrastructure.org/ , namely the criteria:

The project MUST acknowledge a majority of bug reports submitted in the last 2-12 months (inclusive); the response need not include a fix.
The project SHOULD respond to most enhancement requests in the last 2-12 months (inclusive). The project MAY choose not to respond.

Because these are common needs for software projects (even a "mandatory" best practice), it would be inappropriate to address them with a custom solution.

I don't see how Herald rules are related to the provided "example use case" (maybe because it's unclear to me what "MUST acknowledge" actually means). Maniphest's advanced search already allows to combine "Created Before" and "Updated After" to address that "common need" - no Herald needed.

eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:00 PM
nemobis added a comment.EditedJul 16 2016, 8:32 AM

I don't see how Herald rules are related to the provided "example use case"

I'm sorry you have such a vision problem; luckily, the https://bestpractices.coreinfrastructure.org/ people acknowledged the issue with our issue tracker.

@nemobis, I previously warned you about the tone of your interactions with the upstream in T5908#84888.

Acting in a way that demeans and personally attacks others is not acceptable here.

This is your final warning.

With D11419 implemented, is it possible to now allow Herald rules to be triggered on a cron (even a very simple 'daily' option would be good)?

My use case is sending out reminders to auditors that they have audits waiting for them to review. Some of our users don't use phabricator regularly and they forget to come back and review code they have waiting.

I could implement an external API call and script per T7171 but having this contained and managed inside phabricator would be a lot simpler. As I see it, the parts might be:

  1. cron style triggers for herald
  2. filter based on age (this task)
  3. create events which might then be consumed by another herald trigger

Other people might also want to send out a single reminder email with all the aged objects grouped, but the above ideas might be a first step and would be useful for at least my particular use-case.

Thanks for considering this.

epriestley moved this task from Backlog to Next on the Herald board.May 3 2019, 4:53 AM

See PHI1107, which requests Auto-Abandon for old changes and also has a technical outline for this great and wholesome feature.

spawnlt added a subscriber: spawnlt.