Page MenuHomePhabricator
Feed All Stories

Mar 11 2019

epriestley requested review of D20277: Add "Group by Status" to Workboards.
Mar 11 2019, 9:24 PM
epriestley added a revision to T10333: Add groups to workboard columns: D20277: Add "Group by Status" to Workboards.
Mar 11 2019, 9:23 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T10578: Provide 'Sort by Points' option in workboards.
Mar 11 2019, 4:53 PM · Workboards (v3), Feature Request
epriestley requested review of D20276: Implement "Sort by Points" on workboards.
Mar 11 2019, 4:49 PM
epriestley added a revision to T10578: Provide 'Sort by Points' option in workboards: D20276: Implement "Sort by Points" on workboards.
Mar 11 2019, 4:48 PM · Workboards (v3), Feature Request
epriestley requested review of D20275: Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors.
Mar 11 2019, 4:08 PM
epriestley added a revision to T10578: Provide 'Sort by Points' option in workboards: D20275: Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors.
Mar 11 2019, 4:06 PM · Workboards (v3), Feature Request
epriestley added a comment to T10578: Provide 'Sort by Points' option in workboards.

We could lock this order into "drag to column" interactions only once those are built (i.e., not support "drag to position" -- basically, when you drop a card, we fling it into the correct position, even if that position is at the bottom of the column far off the screen). This will be somewhat confusing but maybe the least-bad of the options.

Mar 11 2019, 2:27 PM · Workboards (v3), Feature Request
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T5474: Support workboard column triggers which activate when a task is dropped into a column, as Wontfix.
Mar 11 2019, 2:19 PM · Workboards (v3), Restricted Project
epriestley closed T6502: Policy to define who can move cards in a workboard as Wontfix.

To summarize the state of the world here:

Mar 11 2019, 2:18 PM · Projects, Wikimedia, Policy, Workboards
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)", as Wontfix.
Mar 11 2019, 2:18 PM · Projects, Wikimedia, Workboards
epriestley moved T10578: Provide 'Sort by Points' option in workboards from Backlog to v3 on the Workboards board.
Mar 11 2019, 1:31 PM · Workboards (v3), Feature Request
epriestley moved T12175: Simultaneous task moving on workboards results in error from Backlog to v3 on the Workboards board.
Mar 11 2019, 1:31 PM · Workboards (v3), Bug Report
epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Mar 11 2019, 1:30 PM · Workboards (v3), Plans, Projects
leoluk awarded D20270: Implement "Group by Owner" on Workboards a Love token.
Mar 11 2019, 1:04 PM
epriestley requested review of D20274: Provide better UI feedback about cards that can't be dragged or edited.
Mar 11 2019, 6:03 AM
epriestley added a revision to T10722: Communicate drag policies clearly in the workboard/list UIs: D20274: Provide better UI feedback about cards that can't be dragged or edited.
Mar 11 2019, 6:01 AM · Workboards (v3), Bug Report
epriestley requested review of D20273: Allow MFA task edits to go through on workboards.
Mar 11 2019, 5:35 AM
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20273: Allow MFA task edits to go through on workboards.
Mar 11 2019, 5:34 AM · Workboards (v3), Plans, Projects
epriestley requested review of D20272: Improve rendering of empty workboard columns in header views.
Mar 11 2019, 5:28 AM
epriestley added a revision to T10333: Add groups to workboard columns: D20272: Improve rendering of empty workboard columns in header views.
Mar 11 2019, 5:26 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T10333: Add groups to workboard columns.
Mar 11 2019, 5:24 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley requested review of D20271: When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately.
Mar 11 2019, 5:14 AM
epriestley added a revision to T10333: Add groups to workboard columns: D20271: When creating or editing a card on a sorted/grouped workboard, adjust headers appropriately.
Mar 11 2019, 5:12 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley requested review of D20270: Implement "Group by Owner" on Workboards.
Mar 11 2019, 5:03 AM
epriestley added a revision to T10333: Add groups to workboard columns: D20270: Implement "Group by Owner" on Workboards.
Mar 11 2019, 5:01 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley requested review of D20269: Modularize workboard column orders.
Mar 11 2019, 4:58 AM
epriestley added a revision to T10333: Add groups to workboard columns: D20269: Modularize workboard column orders.
Mar 11 2019, 4:56 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley requested review of D20268: Add "assert_same_keys()" to "libphutil/".
Mar 11 2019, 4:45 AM
epriestley requested review of D20267: Add a "WorkboardCardTemplate" class to make workboard client code easier to reason about.
Mar 11 2019, 3:18 AM
epriestley updated the diff for D20265: On Workboards, sort groups by "natural order", not subpriority.
  • Fix a bug with dragging between columns on a priority-sorted board.
Mar 11 2019, 3:10 AM
epriestley requested review of D20266: Remove all readers/writers for task "subpriority".
Mar 11 2019, 12:34 AM
epriestley added a revision to T10333: Add groups to workboard columns: D20266: Remove all readers/writers for task "subpriority".
Mar 11 2019, 12:32 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added inline comments to D20265: On Workboards, sort groups by "natural order", not subpriority.
Mar 11 2019, 12:27 AM

Mar 10 2019

epriestley requested review of D20265: On Workboards, sort groups by "natural order", not subpriority.
Mar 10 2019, 4:23 PM
epriestley added a revision to T10333: Add groups to workboard columns: D20265: On Workboards, sort groups by "natural order", not subpriority.
Mar 10 2019, 4:22 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley updated the diff for D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
  • Clean up one more piece of code I dug out of the ground.
Mar 10 2019, 3:47 PM

Mar 9 2019

epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 8:34 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:16 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:15 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:12 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:58 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:50 PM · Plans
epriestley added a project to T13263: Plans: 2019 Week 11-15 Bonus Content: Plans.
Mar 9 2019, 6:43 PM · Plans
epriestley triaged T13263: Plans: 2019 Week 11-15 Bonus Content as Normal priority.
Mar 9 2019, 6:43 PM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 9 Bonus Content to 2019 Week 7 - 10 Bonus Content.
Mar 9 2019, 6:42 PM · Plans
epriestley added a comment to T10333: Add groups to workboard columns.

This now exists for priorities. I'd like to get at least one more grouping (likely: assignee) built before calling this resolved since "Priority" has some magic interaction with "subpriority". I'm moving toward getting rid of "subpriority" in D20263, but I'm not yet completely sure that it'll stick.

Mar 9 2019, 6:38 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley closed T8135: drag & drop on a workboard sorted by priority behavior is surprising as Resolved.

Drag-and-drop between columns on a priority-sorted board no longer changes priority. See T13074 for continuing adjacent work.

Mar 9 2019, 6:37 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column", a subtask of T8135: drag & drop on a workboard sorted by priority behavior is surprising, as Resolved.
Mar 9 2019, 6:36 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column" as Resolved.

Some adjacent work in T13074 may build on this, and we might do "drag + shift" at some point, but this is substantially resolved.

Mar 9 2019, 6:35 PM · Workboards (v3)
epriestley added a comment to D20264: Remove opacity effects for left-side / right-side diff text selection.

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

Mar 9 2019, 6:33 PM
epriestley committed rP40af472ff595: Make drag-and-drop on workboards interact with priority column headers (authored by epriestley).
Make drag-and-drop on workboards interact with priority column headers
Mar 9 2019, 6:33 PM
epriestley closed D20248: Make drag-and-drop on workboards interact with priority column headers.
Mar 9 2019, 6:33 PM
epriestley committed rP14a433c77355: Add priority group headers to workboard columns (display only) (authored by epriestley).
Add priority group headers to workboard columns (display only)
Mar 9 2019, 6:33 PM
epriestley closed D20247: Add priority group headers to workboard columns (display only).
Mar 9 2019, 6:33 PM
epriestley added a comment to D20213: Add "phutil_describe_type()" and clean up a few obscure things in "libphutil/".

This [signature] bug isn't a huge issue

Mar 9 2019, 6:32 PM
epriestley committed rPbe1e3b2cc0a8: When a user drags a card over a column, highlight the column border (authored by epriestley).
When a user drags a card over a column, highlight the column border
Mar 9 2019, 6:30 PM
epriestley closed D20245: When a user drags a card over a column, highlight the column border.
Mar 9 2019, 6:30 PM
epriestley committed rP2260738de9e0: When dragging nodes between different columns on an ordered board, don't… (authored by epriestley).
When dragging nodes between different columns on an ordered board, don't…
Mar 9 2019, 6:24 PM
epriestley closed D20242: When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits.
Mar 9 2019, 6:24 PM
epriestley added inline comments to D20213: Add "phutil_describe_type()" and clean up a few obscure things in "libphutil/".
Mar 9 2019, 1:58 PM
epriestley committed rARC8f261fe4750e: Merge branch "master" into "experimental" (authored by epriestley).
Merge branch "master" into "experimental"
Mar 9 2019, 1:20 PM
20after4 added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

I wholeheartedly agree that all that proxy field mess needs to go away. With that gone the only moderately confusing part remaining would be the way in which custom fields interact with herald, email and notifications.

Mar 9 2019, 12:48 PM · Custom Fields, Maniphest
amckinley accepted D20248: Make drag-and-drop on workboards interact with priority column headers.
Mar 9 2019, 7:32 AM

Mar 8 2019

amckinley accepted D20247: Add priority group headers to workboard columns (display only).
Mar 8 2019, 11:26 PM
epriestley edited the content of Changelog.
Mar 8 2019, 3:10 PM
epriestley created 2019 Week 9 (Very Late February).
Mar 8 2019, 3:09 PM
epriestley committed rPHU833574d0b668: (stable) Promote 2019 Week 10 (authored by epriestley).
(stable) Promote 2019 Week 10
Mar 8 2019, 3:08 PM
epriestley committed rARC4d22e0f89f10: (stable) Promote 2019 Week 10 (authored by epriestley).
(stable) Promote 2019 Week 10
Mar 8 2019, 3:08 PM
epriestley committed rP2387a99d71cc: (stable) Promote 2019 Week 10 (authored by epriestley).
(stable) Promote 2019 Week 10
Mar 8 2019, 3:08 PM
epriestley created 2019 Week 10 (Early March).
Mar 8 2019, 3:08 PM
epriestley committed rPc1bff3b8013e: Add an "Restartable: If Failed" behavior to Harbormaster build plans (authored by epriestley).
Add an "Restartable: If Failed" behavior to Harbormaster build plans
Mar 8 2019, 12:48 AM
epriestley closed D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 8 2019, 12:48 AM

Mar 7 2019

epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), a subtask of T13088: Plans: Harbormaster UI usability and interconnectedness, as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley committed rP1d4f6bd44458: Index "Call Webhook" in Herald, and show calling rules on the Webhook page (authored by epriestley).
Index "Call Webhook" in Herald, and show calling rules on the Webhook page
Mar 7 2019, 10:48 PM
epriestley closed D20260: Index "Call Webhook" in Herald, and show calling rules on the Webhook page.
Mar 7 2019, 10:48 PM
epriestley updated the diff for D20260: Index "Call Webhook" in Herald, and show calling rules on the Webhook page.
  • Add the limits to prevent crazy behavior if you write a million rules to call a single hook/plan.
Mar 7 2019, 10:20 PM
epriestley added inline comments to D20260: Index "Call Webhook" in Herald, and show calling rules on the Webhook page.
Mar 7 2019, 10:19 PM
amckinley accepted D20260: Index "Call Webhook" in Herald, and show calling rules on the Webhook page.
Mar 7 2019, 10:12 PM
amckinley accepted D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 7 2019, 10:10 PM
epriestley requested review of D20264: Remove opacity effects for left-side / right-side diff text selection.
Mar 7 2019, 10:07 PM
epriestley committed rP9913754a2aa2: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication… (authored by epriestley).
Improve utilization of "AuthTemporaryToken" table keys in LFS authentication…
Mar 7 2019, 10:02 PM
epriestley closed D20261: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries.
Mar 7 2019, 10:02 PM
epriestley updated the diff for D20261: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries.
  • Typo fix.
Mar 7 2019, 9:54 PM
epriestley added inline comments to D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 9:53 PM
amckinley accepted D20261: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries.
Mar 7 2019, 9:52 PM
epriestley committed rP950a7bbb19e3: On Harbormaster build plans, show which Herald rules trigger builds (authored by epriestley).
On Harbormaster build plans, show which Herald rules trigger builds
Mar 7 2019, 9:52 PM
epriestley closed D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 9:51 PM
amckinley accepted D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 9:47 PM
epriestley committed rARC9830c9316d38: Make minor correctness changes to some "arc patch" command execution (authored by epriestley).
Make minor correctness changes to some "arc patch" command execution
Mar 7 2019, 9:00 PM
epriestley closed D20254: Make minor correctness changes to some "arc patch" command execution.
Mar 7 2019, 9:00 PM
epriestley committed rARC73804f003972: Fix a case where "arc patch" could skip submodule changes (authored by epriestley).
Fix a case where "arc patch" could skip submodule changes
Mar 7 2019, 8:52 PM
epriestley closed D20253: Fix a case where "arc patch" could skip submodule changes.
Mar 7 2019, 8:52 PM
epriestley committed rP77221bee72cb: Allow objects to specify custom policy unlocking behavior, and tasks to have… (authored by epriestley).
Allow objects to specify custom policy unlocking behavior, and tasks to have…
Mar 7 2019, 8:27 PM
epriestley closed D20257: Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked.
Mar 7 2019, 8:27 PM
epriestley committed rPc86dca3ffc80: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern (authored by epriestley).
Update "bin/policy unlock" to be more surgical, flexible, modular, and modern
Mar 7 2019, 8:24 PM
epriestley closed D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.
Mar 7 2019, 8:24 PM
amckinley accepted D20253: Fix a case where "arc patch" could skip submodule changes.
Mar 7 2019, 8:21 PM
amckinley accepted D20254: Make minor correctness changes to some "arc patch" command execution.
Mar 7 2019, 8:19 PM