Page MenuHomePhabricator

Remove all readers/writers for task "subpriority"
ClosedPublic

Authored by epriestley on Mar 11 2019, 12:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 12:46 AM
Unknown Object (File)
Oct 20 2024, 4:11 AM
Unknown Object (File)
Oct 16 2024, 1:05 PM
Unknown Object (File)
Oct 10 2024, 6:59 PM
Unknown Object (File)
Sep 30 2024, 5:13 PM
Unknown Object (File)
Sep 24 2024, 3:00 AM
Unknown Object (File)
Sep 11 2024, 1:39 AM
Unknown Object (File)
Sep 6 2024, 5:53 AM
Subscribers
None

Details

Summary

Depends on D20265. Ref T10333. Now that neither task lists nor workboards use subpriority, we can remove all the readers and writers.

I'm not actually getting rid of the column data yet, but anticipate doing that in a future change.

Note that the subpriority algorithm (removed here) is possibly better than the "natural order" algorithm still in use. It's a bit more clever, and likely performs far fewer writes. I might make the "natural order" code use an algorithm more similar to the "subpriority" algorithm in the future.

Test Plan

Grepped for subpriority.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/maniphest/editor/ManiphestTransactionEditor.php
404–406

This is nuts; I had no idea this code was so complicated.

This revision is now accepted and ready to land.Mar 12 2019, 6:54 PM

Oh, I didn't submit this comment:

src/applications/maniphest/editor/ManiphestTransactionEditor.php
404–421

Particularly, this is the clever bit.

This revision was automatically updated to reflect the committed changes.