Page MenuHomePhabricator

Remove all readers/writers for task "subpriority"
ClosedPublic

Authored by epriestley on Mon, Mar 11, 12:32 AM.

Details

Summary

Depends on D20265. Ref T10333. Now that neither task lists nor workboards use subpriority, we can remove all the readers and writers.

I'm not actually getting rid of the column data yet, but anticipate doing that in a future change.

Note that the subpriority algorithm (removed here) is possibly better than the "natural order" algorithm still in use. It's a bit more clever, and likely performs far fewer writes. I might make the "natural order" code use an algorithm more similar to the "subpriority" algorithm in the future.

Test Plan

Grepped for subpriority.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, Mar 11, 12:32 AM
epriestley requested review of this revision.Mon, Mar 11, 12:34 AM
amckinley accepted this revision.Tue, Mar 12, 6:54 PM
amckinley added inline comments.
src/applications/maniphest/editor/ManiphestTransactionEditor.php
404–406

This is nuts; I had no idea this code was so complicated.

This revision is now accepted and ready to land.Tue, Mar 12, 6:54 PM

Oh, I didn't submit this comment:

src/applications/maniphest/editor/ManiphestTransactionEditor.php
404–421

Particularly, this is the clever bit.

This revision was automatically updated to reflect the committed changes.