HomePhabricator

Make minor correctness changes to some "arc patch" command execution

Description

Make minor correctness changes to some "arc patch" command execution

Summary:
Since I'm in here for PHI1083:

  • Add some "--" so we get correct behavior when you have a file named "master", a branch named "README.txt", etc.
  • Stop using "%C" unnecessarily.
  • Fix some untranslatable strings.

Test Plan: Ran arc patch a couple of times, ran the variations of git commands to catch anything weird with "--" handling.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20254

Details

Provenance
epriestleyAuthored on Mar 6 2019, 6:51 PM
epriestleyPushed on Mar 7 2019, 9:00 PM
Reviewer
amckinley
Differential Revision
D20254: Make minor correctness changes to some "arc patch" command execution
Parents
rARC73804f003972: Fix a case where "arc patch" could skip submodule changes
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22225
Build 30387: Run Core Tests