Page MenuHomePhabricator
Feed All Stories

Mar 7 2019

epriestley updated the summary of D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.
Mar 7 2019, 8:16 PM
amckinley accepted D20257: Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked.
Mar 7 2019, 8:16 PM
amckinley added a comment to D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.

Oh, I didn't see D20257. Carry on.

Mar 7 2019, 8:15 PM
amckinley accepted D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.
Mar 7 2019, 8:14 PM
epriestley committed rPbacf1f44e00f: Modularize HeraldRule transactions (authored by epriestley).
Modularize HeraldRule transactions
Mar 7 2019, 7:55 PM
epriestley closed D20258: Modularize HeraldRule transactions.
Mar 7 2019, 7:55 PM
epriestley updated the diff for D20258: Modularize HeraldRule transactions.
  • Remove unused variable.
Mar 7 2019, 7:53 PM
epriestley committed rP9918ea1fb7ca: Fix an exception with user cache generation in "bin/conduit call --as <user>" (authored by epriestley).
Fix an exception with user cache generation in "bin/conduit call --as <user>"
Mar 7 2019, 7:48 PM
epriestley closed D20255: Fix an exception with user cache generation in "bin/conduit call --as <user>".
Mar 7 2019, 7:48 PM
epriestley committed rPa3ebaac0f026: Tweak the visual style of the ">>" / "<<" depth change indicators slightly (authored by epriestley).
Tweak the visual style of the ">>" / "<<" depth change indicators slightly
Mar 7 2019, 7:46 PM
epriestley closed D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly.
Mar 7 2019, 7:46 PM
epriestley committed rPHU6c64dce5f71c: Render query strings into concrete scalar "string" values immediately, not… (authored by epriestley).
Render query strings into concrete scalar "string" values immediately, not…
Mar 7 2019, 7:44 PM
epriestley closed D20249: Render query strings into concrete scalar "string" values immediately, not lazily.
Mar 7 2019, 7:44 PM
epriestley added inline comments to D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
Mar 7 2019, 7:43 PM
epriestley requested review of D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
Mar 7 2019, 7:43 PM
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: D20263: Remove the ability to drag tasks up and down on (non-Workboard) priority list views.
Mar 7 2019, 7:41 PM · Workboards (v3), Plans, Projects
amckinley accepted D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly.
Mar 7 2019, 6:53 PM
epriestley added a comment to D20245: When a user drags a card over a column, highlight the column border.

There are four separate UI feedback indicators right now:

Mar 7 2019, 6:50 PM
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

An adjacent issue is that the current behavior of overheated queries is to return a partial result set and set a flag. The goal of this behavior is to let us show some results if we find some results, but it may be surprising if the caller doesn't handle overheated queries, since they may look like a queries which simply failed to match anything.

Mar 7 2019, 6:43 PM · Diffusion
amckinley accepted D20245: When a user drags a card over a column, highlight the column border.

This is very tricky to take a screenshot of.

Mar 7 2019, 6:43 PM
epriestley retitled D20258: Modularize HeraldRule transactions from Modularize Herald transactions to Modularize HeraldRule transactions.
Mar 7 2019, 6:40 PM
amckinley accepted D20258: Modularize HeraldRule transactions.
Mar 7 2019, 6:40 PM
leoluk awarded D20247: Add priority group headers to workboard columns (display only) a Love token.
Mar 7 2019, 6:39 PM
amckinley accepted D20249: Render query strings into concrete scalar "string" values immediately, not lazily.
Mar 7 2019, 6:37 PM
amckinley accepted D20242: When dragging nodes between different columns on an ordered board, don't reorder them by making secondary edits.
Mar 7 2019, 6:35 PM
amckinley accepted D20255: Fix an exception with user cache generation in "bin/conduit call --as <user>".
Mar 7 2019, 6:34 PM
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

The hypothetical steps above do, in fact, reproduce this:

Mar 7 2019, 6:17 PM · Diffusion
epriestley planned changes to D20262: Reuse recently issued Git LFS authentication tokens.

Not sure about moving this forward.

Mar 7 2019, 5:26 PM
epriestley requested review of D20262: Reuse recently issued Git LFS authentication tokens.
Mar 7 2019, 5:26 PM
epriestley requested review of D20261: Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries.
Mar 7 2019, 4:36 PM
epriestley updated the diff for D20260: Index "Call Webhook" in Herald, and show calling rules on the Webhook page.
  • Push fixes for null/empty behavior back to the previous revision.
Mar 7 2019, 3:24 PM
epriestley updated the diff for D20259: On Harbormaster build plans, show which Herald rules trigger builds.
  • Minor fixes for null/empty behaviors.
Mar 7 2019, 3:23 PM
epriestley requested review of D20260: Index "Call Webhook" in Herald, and show calling rules on the Webhook page.
Mar 7 2019, 2:39 PM
epriestley requested review of D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 2:24 PM
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20259: On Harbormaster build plans, show which Herald rules trigger builds.
Mar 7 2019, 2:22 PM · Plans, Harbormaster
epriestley requested review of D20258: Modularize HeraldRule transactions.
Mar 7 2019, 1:04 PM
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20258: Modularize HeraldRule transactions.
Mar 7 2019, 1:02 PM · Plans
epriestley requested review of D20257: Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked.
Mar 7 2019, 4:54 AM
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20257: Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked.
Mar 7 2019, 4:52 AM · Plans
epriestley requested review of D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.
Mar 7 2019, 4:43 AM
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.
Mar 7 2019, 4:42 AM · Plans
jbrownEP added a comment to T9069: arc patch can't handle binary file correctly.

It seems that newer versions of git have become more aggressive at detecting binary changes as moves + renames, because my install is now hitting this on a very frequent basis

Mar 7 2019, 12:47 AM · Differential, Restricted Project, Arcanist
epriestley requested review of D20255: Fix an exception with user cache generation in "bin/conduit call --as <user>".
Mar 7 2019, 12:28 AM
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20255: Fix an exception with user cache generation in "bin/conduit call --as <user>".
Mar 7 2019, 12:26 AM · Plans
jmeador awarded rPd36d0efc3570: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing… a Burninate token.
Mar 7 2019, 12:11 AM
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 7 2019, 12:07 AM · Plans

Mar 6 2019

epriestley requested review of D20254: Make minor correctness changes to some "arc patch" command execution.
Mar 6 2019, 6:54 PM
epriestley requested review of D20253: Fix a case where "arc patch" could skip submodule changes.
Mar 6 2019, 6:45 PM
epriestley requested review of D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 6 2019, 5:41 PM
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 6 2019, 5:39 PM · Plans, Harbormaster
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20252: Add an "Restartable: If Failed" behavior to Harbormaster build plans.
Mar 6 2019, 5:39 PM · Plans
epriestley added a comment to D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly.

Indent Depth Increased, Old:

Mar 6 2019, 4:37 PM
epriestley requested review of D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly.
Mar 6 2019, 4:37 PM
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: D20251: Tweak the visual style of the ">>" / "<<" depth change indicators slightly.
Mar 6 2019, 4:36 PM · Plans
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

In the future, when a board can be ordered/grouped by author or assignee (or maybe custom fields), what should dragging a card within a column do?

Mar 6 2019, 3:11 PM · Workboards (v3), Plans, Projects
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 6 2019, 2:54 PM · Plans
epriestley committed rARCf6b8480adce5: Implement "Warn When Landing" behavior for Build Plans in Arcanist (authored by epriestley).
Implement "Warn When Landing" behavior for Build Plans in Arcanist
Mar 6 2019, 2:48 PM
epriestley closed D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 6 2019, 2:48 PM
epriestley updated the diff for D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
  • Typos/spelling.
Mar 6 2019, 2:35 PM
epriestley added inline comments to D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 6 2019, 2:35 PM
epriestley committed rP7e4681234467: Add a warning to revision timelines when changes land with ongoing or failed… (authored by epriestley).
Add a warning to revision timelines when changes land with ongoing or failed…
Mar 6 2019, 2:32 PM
epriestley closed D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
Mar 6 2019, 2:32 PM
epriestley committed rPf97df9ebea90: Implement Build Plan behavior "Affects Buildable" (authored by epriestley).
Implement Build Plan behavior "Affects Buildable"
Mar 6 2019, 2:30 PM
epriestley closed D20233: Implement Build Plan behavior "Affects Buildable".
Mar 6 2019, 2:30 PM
Harbormaster failed to build B22197: rP718cdc24471a: Implement Build Plan "Hold Drafts" behavior for rP718cdc24471a: Implement Build Plan "Hold Drafts" behavior!
Mar 6 2019, 2:29 PM
epriestley committed rP718cdc24471a: Implement Build Plan "Hold Drafts" behavior (authored by epriestley).
Implement Build Plan "Hold Drafts" behavior
Mar 6 2019, 2:28 PM
epriestley closed D20232: Implement Build Plan "Hold Drafts" behavior.
Mar 6 2019, 2:27 PM
epriestley committed rP578de333dfa5: Make the new Build Plan behavior "Restartable" work (authored by epriestley).
Make the new Build Plan behavior "Restartable" work
Mar 6 2019, 2:26 PM
epriestley closed D20230: Make the new Build Plan behavior "Restartable" work.
Mar 6 2019, 2:26 PM
epriestley committed rPee0ad4703ebd: Make the new Build Plan "Runnable" behavior work (authored by epriestley).
Make the new Build Plan "Runnable" behavior work
Mar 6 2019, 2:01 PM
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them as Resolved by committing rPee0ad4703ebd: Make the new Build Plan "Runnable" behavior work.
Mar 6 2019, 2:01 PM · Restricted Project, Harbormaster, Feature Request
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them, a subtask of T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), as Resolved.
Mar 6 2019, 2:01 PM · Plans, Harbormaster
epriestley closed D20229: Make the new Build Plan "Runnable" behavior work.
Mar 6 2019, 2:01 PM
epriestley updated the diff for D20229: Make the new Build Plan "Runnable" behavior work.
  • Describe "run" and "pause/abort/resume/restart" in two different rules to get rid of weird compound clauses.
Mar 6 2019, 1:57 PM
epriestley added inline comments to D20229: Make the new Build Plan "Runnable" behavior work.
Mar 6 2019, 1:55 PM
epriestley committed rP983cf885e7ce: Expose Build Plan behaviors via "harbormaster.buildplan.search" (authored by epriestley).
Expose Build Plan behaviors via "harbormaster.buildplan.search"
Mar 6 2019, 1:47 PM
epriestley closed D20228: Expose Build Plan behaviors via "harbormaster.buildplan.search".
Mar 6 2019, 1:47 PM
epriestley committed rPd36d0efc3570: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing… (authored by epriestley).
Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing…
Mar 6 2019, 1:40 PM
epriestley closed D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.
Mar 6 2019, 1:40 PM
epriestley updated the diff for D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.
  • Wordsmithing.
  • Use "sent for review" over "promoted from draft".
  • Use "wait for the build" over "wait for the build to complete to pass".
  • Try to make "X, and/but Y" structure a little more consistent.
  • Improve clarity of "land" condition.
Mar 6 2019, 1:34 PM
epriestley added inline comments to D20220: Add behaviors to Build Plans: hold drafts, affect buildables, warn on landing, restartable, runnable.
Mar 6 2019, 1:32 PM

Mar 5 2019

epriestley abandoned D20250: In "qsprintf()", don't render the unmasked query string unless it will differ from the masked string.

I can't get anything remotely convincing out of ab. This or some similar change might still be a good idea, but I'll wait until I have a clearer case for it.

Mar 5 2019, 10:38 PM
epriestley requested review of D20250: In "qsprintf()", don't render the unmasked query string unless it will differ from the masked string.
Mar 5 2019, 10:18 PM
epriestley updated the diff for D20249: Render query strings into concrete scalar "string" values immediately, not lazily.
  • Minor tidying.
Mar 5 2019, 9:43 PM
epriestley requested review of D20249: Render query strings into concrete scalar "string" values immediately, not lazily.
Mar 5 2019, 9:42 PM
epriestley abandoned D20067: Slightly improve performance of querystring construction by caching results.

I'm going to take another run at this, but from a slightly different angle.

Mar 5 2019, 9:23 PM
epriestley committed rPea6c0c9bdebf: Refine the "Mangled Webserver Response" setup check (authored by epriestley).
Refine the "Mangled Webserver Response" setup check
Mar 5 2019, 8:58 PM
epriestley closed D20235: Refine the "Mangled Webserver Response" setup check.
Mar 5 2019, 8:58 PM
amckinley accepted D20236: Implement "Warn When Landing" behavior for Build Plans in Arcanist.
Mar 5 2019, 8:04 PM
amckinley accepted D20235: Refine the "Mangled Webserver Response" setup check.
Mar 5 2019, 7:57 PM
epriestley added a comment to D20230: Make the new Build Plan behavior "Restartable" work.

I haven't seen any of that so far, but it seems pretty reasonable to me. Maybe I'll just add it unless I can come up with some reason why it's secretly bad in the time it takes to implement.

Mar 5 2019, 7:55 PM
amckinley accepted D20233: Implement Build Plan behavior "Affects Buildable".
Mar 5 2019, 7:52 PM
amckinley accepted D20232: Implement Build Plan "Hold Drafts" behavior.
Mar 5 2019, 7:49 PM
amckinley accepted D20230: Make the new Build Plan behavior "Restartable" work.

Does anyone want an option for "only allow builds that have failed to be restarted"? For cases where builds are idempotent except for a final irrevocable step like "find servers running any version of the code != this version and kill them"?

Mar 5 2019, 7:47 PM
epriestley updated the diff for D20239: Add a warning to revision timelines when changes land with ongoing or failed builds.
  • Spelling.
Mar 5 2019, 7:39 PM
amckinley accepted D20229: Make the new Build Plan "Runnable" behavior work.
Mar 5 2019, 7:38 PM
epriestley committed rPc116deef6398: Remove "Effective User" attachment from Repository Identities (authored by epriestley).
Remove "Effective User" attachment from Repository Identities
Mar 5 2019, 7:35 PM
epriestley closed D20224: Remove "Effective User" attachment from Repository Identities.
Mar 5 2019, 7:35 PM
epriestley committed rPcc8dda629905: Recognize the official "Go" magic regexp for generated code as generated (authored by epriestley).
Recognize the official "Go" magic regexp for generated code as generated
Mar 5 2019, 7:34 PM
epriestley closed D20237: Recognize the official "Go" magic regexp for generated code as generated.
Mar 5 2019, 7:34 PM