Page MenuHomePhabricator

Make minor correctness changes to some "arc patch" command execution
ClosedPublic

Authored by epriestley on Mar 6 2019, 6:54 PM.
Tags
None
Referenced Files
F19547158: D20254.id48366.diff
Sun, Jan 25, 10:56 PM
F19530982: D20254.id48366.diff
Tue, Jan 20, 1:31 AM
F19519316: D20254.id.diff
Fri, Jan 16, 4:18 AM
F19517543: D20254.diff
Thu, Jan 15, 12:11 PM
F19082952: D20254.id48366.diff
Dec 2 2025, 12:28 PM
F18985074: D20254.id48346.diff
Nov 17 2025, 12:52 PM
F18808689: D20254.id48366.diff
Oct 19 2025, 7:58 AM
F18757007: D20254.diff
Oct 5 2025, 3:01 PM
Subscribers
None

Details

Summary

Since I'm in here for PHI1083:

  • Add some "--" so we get correct behavior when you have a file named "master", a branch named "README.txt", etc.
  • Stop using "%C" unnecessarily.
  • Fix some untranslatable strings.
Test Plan

Ran arc patch a couple of times, ran the variations of git commands to catch anything weird with "--" handling.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable