Page MenuHomePhabricator

Make minor correctness changes to some "arc patch" command execution
ClosedPublic

Authored by epriestley on Wed, Mar 6, 6:54 PM.

Details

Summary

Since I'm in here for PHI1083:

  • Add some "--" so we get correct behavior when you have a file named "master", a branch named "README.txt", etc.
  • Stop using "%C" unnecessarily.
  • Fix some untranslatable strings.
Test Plan

Ran arc patch a couple of times, ran the variations of git commands to catch anything weird with "--" handling.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Mar 6, 6:54 PM
epriestley requested review of this revision.Wed, Mar 6, 6:54 PM
amckinley accepted this revision.Thu, Mar 7, 8:19 PM
This revision is now accepted and ready to land.Thu, Mar 7, 8:19 PM
This revision was automatically updated to reflect the committed changes.