Page MenuHomePhabricator

Remove opacity effects for left-side / right-side diff text selection
ClosedPublic

Authored by epriestley on Thu, Mar 7, 10:06 PM.

Details

Summary

These effects feel like they're possibly overkill, since other CSS rules make the selection reticle behave correctly and the implementation is relatively intuitive.

Or not, either way.

Test Plan

Selected text on either side of a 2-up diff, no more opacity effects.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Mar 7, 10:06 PM
epriestley requested review of this revision.Thu, Mar 7, 10:07 PM

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

amckinley accepted this revision.Tue, Mar 12, 6:38 PM

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

Ditto.

This revision is now accepted and ready to land.Tue, Mar 12, 6:38 PM
This revision was automatically updated to reflect the committed changes.