Page MenuHomePhabricator

Remove opacity effects for left-side / right-side diff text selection
ClosedPublic

Authored by epriestley on Mar 7 2019, 10:06 PM.
Tags
None
Referenced Files
F14078015: D20264.diff
Fri, Nov 22, 1:46 AM
Unknown Object (File)
Sun, Nov 17, 4:45 PM
Unknown Object (File)
Thu, Nov 14, 10:50 AM
Unknown Object (File)
Tue, Nov 12, 6:44 AM
Unknown Object (File)
Sat, Nov 9, 4:40 PM
Unknown Object (File)
Wed, Nov 6, 3:55 AM
Unknown Object (File)
Oct 16 2024, 6:54 PM
Unknown Object (File)
Aug 30 2024, 1:10 AM
Subscribers
None

Details

Summary

These effects feel like they're possibly overkill, since other CSS rules make the selection reticle behave correctly and the implementation is relatively intuitive.

Or not, either way.

Test Plan

Selected text on either side of a 2-up diff, no more opacity effects.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

I think I lean toward "yeah, let's get rid of this" after sleeping on it.

Ditto.

This revision is now accepted and ready to land.Mar 12 2019, 6:38 PM
This revision was automatically updated to reflect the committed changes.