Page MenuHomePhabricator

Improve utilization of "AuthTemporaryToken" table keys in LFS authentication queries
ClosedPublic

Authored by epriestley on Thu, Mar 7, 4:34 PM.

Details

Summary

See PHI1123. The key on this table is <resource, type, code> but we currently query for only <type, code>. This can't use the key.

Constrain the query to the resource we expect (the repository) so it can use the key.

Test Plan

Pushed files using LFS. See PHI1123 for more, likely.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Mar 7, 4:34 PM
epriestley requested review of this revision.Thu, Mar 7, 4:36 PM
amckinley accepted this revision.Thu, Mar 7, 9:52 PM
amckinley added inline comments.
src/applications/diffusion/controller/DiffusionServeController.php
677

"resource"

This revision is now accepted and ready to land.Thu, Mar 7, 9:52 PM
epriestley updated this revision to Diff 48368.Thu, Mar 7, 9:54 PM
  • Typo fix.
This revision was automatically updated to reflect the committed changes.