Page MenuHomePhabricator

Implement "Group by Owner" on Workboards
ClosedPublic

Authored by epriestley on Mar 11 2019, 5:01 AM.

Details

Summary

Depends on D20269. Ref T10333. Now that orderings are modularized, this is fairly easy to implement. This isn't super fancy for now (e.g., no profile images) but I'll touch it up in a general polish followup.

Test Plan

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 11 2019, 5:01 AM
epriestley requested review of this revision.Mar 11 2019, 5:03 AM
amckinley accepted this revision.Mar 12 2019, 7:53 PM
amckinley added inline comments.
src/applications/project/order/PhabricatorProjectColumnOwnerOrder.php
73

"by the owner's"

82–84

Maybe sort them all into a single "Invalid Owner" bucket?

This revision is now accepted and ready to land.Mar 12 2019, 7:53 PM
epriestley updated this revision to Diff 48405.Mar 12 2019, 8:16 PM
  • Typo correction.

I think the "Invalid Owner" case is likely very rare and having more information may be helpful in sorting it out, but there's no reason we couldn't do a single "invalid" bucket if that doesn't prove to be the case.

Other groupings like "priority" and "status" can end up with database values that have no display value, and I think the extra headers are probably helpful on the balance there, since sometimes they point directly at a corrective action (usually: reverting changes to configuration to put back priorities or statuses that you incorrectly got rid of). In these cases, at least, it seems more helpful to have an Unknown Status ("waylayed") header than an Invalid Status header, although admittedly it's less likely that anyone can take specific corrective action based on Unknown User ("PHID-USER-xyz") vs Invalid Owner.

This revision was automatically updated to reflect the committed changes.